Error message Strict standards Non-static method should not be called statically in php

Question

I have the following php  However when I see the index php I get the following error message       Strict standards  Non-static method   Page  getInstanceByName   should not   be called statically in    var www webworks index php on line 12   I am hoping someone can tell me how to fix the problem   index php       common variables and functions include once  ww incs common php     page isset   REQUEST  page      REQUEST  page        id isset   REQUEST  id     int   REQUEST  id   0            get current page id if   id       if  page      load by name          r Page  getInstanceByName  page           if  r  amp  amp  isset  r- gt id   id  r- gt id            if   id      else load by special          special 1          if   page                r Page  getInstanceBySpecial  special               if  r  amp  amp  isset  r- gt id   id  r- gt id                          load page data if  id        PAGEDATA  isset  r   amp  amp   r   r   Page  getInstance  id     else      echo  404 thing goes here       exit              ww incs common php   lt  php require dirname   FILE      basics php             ww incs basics php  session start    if  function exists    autoload         function   autoload  name            require  name     php                     Page php  class Page      static  instances               array        static  instancesByName       array        static  instancesBySpecial     array        function   construct  v  byField 0  fromRow 0  pvq 0             byField  0 ID  1 Name  3 special         if    byField  amp  amp  is numeric  v       by ID              r  fromRow  fromRow   v dbRow  select   from pages where id  v limit 1   array                       else if   byField    1      by name              name strtolower str replace  -       v                 fname  page by name   md5  name                r dbRow  select   from pages where name like    addslashes  name     limit 1                      else if   byField    3  amp  amp  is numeric  v       by special              fname  page by special    v               r dbRow  select   from pages where special amp  v limit 1                      else return false          if  count  r     is array  r   return false          if  isset  r  id     r  id   0          if  isset  r  type     r  type   0          if  isset  r  special     r  special   0          if  isset  r  name     r  name    NO NAME SUPPLIED           foreach   r as  k  gt  v   this- gt   k   v           this- gt urlname  r  name             this- gt dbVals  r          self   instances  this- gt id    amp   this          self   instancesByName preg replace     a-z0-9     -  strtolower  this- gt urlname      amp   this          self   instancesBySpecial  this- gt special    amp   this          if   this- gt vars  this- gt vars                this- gt vars json decode  this- gt vars             function getInstance  id 0  fromRow false  pvq false           if   is numeric  id   return false          if    array key exists  id self   instances   self   instances  id  new Page  id 0  fromRow  pvq           return self   instances  id             function getInstanceByName  name               name strtolower  name            nameIndex preg replace     a-z0-9      -   name           if  array key exists  nameIndex self   instancesByName  return self   instancesByName  nameIndex           self   instancesByName  nameIndex  new Page  name 1           return self   instancesByName  nameIndex             function getInstanceBySpecial  sp 0           if   is numeric  sp   return false          if    array key exists  sp  instancesBySpecial    instancesBySpecial  sp  new Page  sp 3           return  instancesBySpecial  sp

User · Answer

use className- function    instead className  function

User · Answer

Your methods are missing the static keyword  Change  function getInstanceByName  name        to  public static function getInstanceByName  name        if you want to call them statically    Note that static methods  and Singletons  are death to testability   Also note that you are doing way too much work in the constructor  especially all that querying shouldn t be in there  All your constructor is supposed to do is set the object into a valid state  If you have to have data from outside the class to do that consider injecting it instead of pulling it  Also note that constructors cannot return anything  They will always return void so all these return false statements do nothing but end the construction

User · Answer

I think this may answer your question   Non-static method       should not be called statically  If the method is not static you need to initialize it like so    var   new ClassName     var- gt method      Or  in PHP 5 4   you can use this syntax    new ClassName - gt method

User · Answer

Try this    r   Page  - gt getInstanceByName  page     It worked for me in a similar case

User · Answer

Instead of using the instance with the scope resolution operator    because it wasn t defined like static function     r Page  getInstanceByName  page     change it to      r Page- gt getInstanceByName  page     And it will work like a charm

User · Answer

return false is usually meant to terminate the object creation with a failure  It is as simple as that

User · Answer

If scope resolution    had to be used outside the class then the respective function or variable should be declared as static  class Foo              Static variable          public static  static var    static variable              Static function          static function staticValue     return  static function                 function          function Value     return  Object             echo Foo   static var     lt br  gt    echo Foo  staticValue      lt br  gt     foo   new Foo    echo  foo- gt Value

[php] Error message Strict standards: Non-static method should not be called statically in php

Examples related to php

Examples related to static-members