Find largest and smallest number in an array

Question

Consider    include  lt iostream gt     Include header file  using namespace std   int main      start of main function        int values 20      Declares array and how many elements     int small  big     Declares integer     big   small   values 0      Assigns element to be highest or lowest value      for  int i   0  i  lt  20  i       Counts to 20 and prompts the user for a value and stores it               cout  lt  lt   Enter value    lt  lt  i  lt  lt                cin  gt  gt  values i              for  int i   0  i  lt  20  i       Works out the biggest number               if values i   gt  big     Compare biggest value with current element                       big   values i                        for  int i   0  i  lt  20  i       Works out the smallest number               if  values i   lt  small     Compares smallest value with current element                       small   values i                        cout  lt  lt   The biggest number is    lt  lt  big  lt  lt  endl     Prints outs the biggest number     cout  lt  lt   The smallest number is    lt  lt  small  lt  lt  endl     Prints out the smallest number     This is my code so far  The problem I am having is with it printing out the biggest number of the array  Something to do with assigning the first element to the highest and lowest value  It works if I do them separately  Any suggestions

User · Answer

You assign to big and small before the array is initialized, i.e., big and small assume the value of whatever is on the stack at this point. As they are just plain value types and no references, they won't assume a new value once values[0] is written to via cin >>.

Just move the assignment after your first loop and it should be fine.

User · Answer

Unless you really must implement your own solution  you can use std  minmax element  This returns a pair of iterators  one to the smallest element and one to the largest    include  lt algorithm gt   auto minmax   std  minmax element std  begin values   std  end values     std  cout  lt  lt   min element    lt  lt    minmax first   lt  lt    n   std  cout  lt  lt   max element    lt  lt    minmax second   lt  lt    n

User · Answer

big small values 0     assigns element to be highest or lowest value   Should be AFTER fill loop    counts to 20 and prompts user for value and stores it for   int i   0  i  lt  20  i           cout  lt  lt   Enter value    lt  lt  i  lt  lt            cin  gt  gt  values i     big small values 0     assigns element to be highest or lowest value   since when you declare array - it s unintialized  store some undefined values  and so  your big and small after assigning would store undefined values too   And of course  you can use std  min element  std  max element  or std  minmax element from C  11  instead of writing your loops

User · Answer

You can initialize after filling the array or you can write    small    unsigned 0  2     Using the bit-wise complement to flip 0 s bits and dividing by 2 because unsigned can hold twice the  ve value an   integer can hold    big  - 1  small  - 1    instead of   big   small   values 0    because when you write this line before filling the array  big and small values will equal to a random leftover value  as integer is a POD  from the memory and if those numbers are either bigger or smaller than any other value in you array  you will get them as an output

User · Answer

int main      start of main fcn        int values  20      delcares array and how many elements     int small big    declares integer      for   int i   0  i  lt  20  i       counts to 20 and prompts user for value and stores it               cout  lt  lt   Enter value    lt  lt  i  lt  lt                cin  gt  gt  values i             big small values 0     assigns element to be highest or lowest value     for  int i   0  i  lt  20  i      works out bigggest number               if values i  gt big    compare biggest value with current element                       big values i                      if values i  lt small    compares smallest value with current element                       small values i                        cout  lt  lt   The biggest number is    lt  lt  big  lt  lt  endl    prints outs biggest no     cout  lt  lt   The smallest number is    lt  lt  small  lt  lt  endl    prints out smalles no

[c++] Find largest and smallest number in an array

Examples related to c++

Examples related to arrays