WPF MVVM How to close a window

Question

I have a Button that closes my window when it s clicked    lt Button x Name  buttonOk   IsCancel  True  gt Ok lt  Button gt    That s fine until I add a Command to the Button i e    lt Button x Name  buttonOk           Command   Binding SaveCommand            IsCancel  True  gt Ok lt  Button gt    Now it doesn t close presumably because I am handling the Command  I can fix this by putting an EventHandler in and calling this Close   i e     lt Button x Name  buttonOk           Click  closeWindow           Command   Binding SaveCommand            IsCancel  True  gt Ok lt  Button gt    but now I have code in my code behind i e  the method SaveCommand  I am using the MVVM pattern and SaveCommand is the only code in my code behind    How can I do this differently so as not to use code behind

User · Answer

This might helps you  closing a wpf window using mvvm with minimal code behind   http   jkshay com closing-a-wpf-window-using-mvvm-and-minimal-code-behind

User · Answer

I struggled with this topic for some time  and eventually went with the simplest approach that is still consistent with MVVM  Have the button execute the Command that does all the heavy lifting and have the button s Click handler close the window   XAML   lt Button x Name  buttonOk           Click  closeWindow           Command   Binding SaveCommand     gt    XAML cs  public void closeWindow          this DialogResult   true      SaveCommand cs      I m in my own file  not the code-behind    True  there is still code-behind  but there isn t anything inherently bad about that  And it makes the most sense to me  from an OO perspective  to just tell the window to close itself

User · Answer

I have following solution in Silverlight  Would also be in WPF   ChildWindowExt cs   namespace System Windows Controls       public class ChildWindowExt   ChildWindow               public static readonly DependencyProperty IsOpenedProperty             DependencyProperty Register             IsOpened             typeof bool             typeof ChildWindowExt             new PropertyMetadata false  IsOpenedChanged             private static void IsOpenedChanged DependencyObject d  DependencyPropertyChangedEventArgs e                        if   bool e NewValue    false                                ChildWindowExt window   d as ChildWindowExt                  window Close                              else if   bool e NewValue    true                                ChildWindowExt window   d as ChildWindowExt                  window Show                                     public bool IsOpened                       get   return  bool GetValue IsOpenedProperty                 set   SetValue IsOpenedProperty  value                        protected override void OnClosing ComponentModel CancelEventArgs e                        this IsOpened   false              base OnClosing e                      protected override void OnOpened                         this IsOpened   true              base OnOpened                        ItemWindow xaml    lt extControls ChildWindowExt       x Class  MyProject ItemWindow      xmlns  http   schemas microsoft com winfx 2006 xaml presentation       xmlns x  http   schemas microsoft com winfx 2006 xaml       xmlns extControls  clr-namespace System Windows Controls      Title   Binding Title   IsOpened   Binding IsOpened  Mode TwoWay   Width  640  Height  480  gt        lt Grid x Name  LayoutRoot  gt           lt Button Command   Binding UpdateCommand   Content  OK  Width  70  HorizontalAlignment  Center  VerticalAlignment  Center   gt       lt  Grid gt    lt  extControls ChildWindowExt gt    ItemViewModel cs   private bool  IsOpened  public bool IsOpened       get               return  IsOpened            set               if   Equals  IsOpened  value                          IsOpened   value              RaisePropertyChanged  IsOpened                       private RelayCommand  UpdateCommand       lt summary gt      Insert   Update data entity      lt  summary gt  public RelayCommand UpdateCommand       get               if   UpdateCommand    null                         UpdateCommand   new RelayCommand                       gt                                           Insert   Update data entity                                              IsOpened   false                                          gt                                        return true                                        return  UpdateCommand            ItemsViewModel cs       private RelayCommand  InsertItemCommand           lt summary gt                    lt  summary gt      public RelayCommand InsertItemCommand               get                       if   InsertItemCommand    null                                 InsertItemCommand   new RelayCommand                           gt                                                ItemWindow itemWin   new ItemWindow                            itemWin DataContext   new ItemViewModel                            itemWin Show                                OR                             ItemWindow itemWin   new ItemWindow                               ItemViewModel newItem   new ItemViewModel                               itemWin DataContext   newItem                             newItem IsOpened   true                                                   gt                                                return true                                                    return  InsertItemCommand                    MainPage xaml    lt Grid x Name  LayoutRoot  gt       lt Button Command   Binding InsertItemCommand   Content  Add New  Width  70  HorizontalAlignment  Left  VerticalAlignment  Center    gt   lt  Grid gt    I wish you all good ideas and projects  -

User · Answer

In your current window xaml cs file  call the below code   var curWnd   Window GetWindow this      passing current window context curWnd  Close      This should do the thing  It worked for me  hope will do the same for you

User · Answer

You could rephrase the question  and by doing so - coming up with another solution   How can I enable communication between views  viewmodels and whatnot in an MVVM environment  You could use the Mediator pattern  It s basically a notification system  For the actual Mediator implementation  google for it or ask me and I can email it   Make a Command whose purpose is to close the view      public void Execute  object parameter         this viewModel DisposeMyStuff        Mediator NotifyColleagues Mediator Token ConfigWindowShouldClose       The Mediator will raise a notification  a token   Listen to this notification  token  like this in the View codebehind constructor   public ClientConfigView         InitializeComponent        Mediator ListenOn Mediator Token ConfigWindowShouldClose  callback   gt  this Close

User · Answer

We have the name property in the  xaml definition   x Name  WindowsForm    Then we have the button     lt Button Command   Binding CloseCommand    CommandParameter   Binding ElementName WindowsForm     gt    Then in the ViewModel   public DelegateCommand  lt Object gt   CloseCommand   get  private set     Constructor for that view model  this CloseCommand   new DelegateCommand lt object gt  this CloseAction     Then at last  the action method   private void CloseAction  object obj      Window Win   obj as Window    Win Close         I used this code to close a pop-up window from an application

User · Answer

Very clean and MVVM way is to use InteractionTrigger and CallMethodAction defined in Microsoft Interactivity Core  You will need to add a new namespace as below   xmlns i  http   schemas microsoft com xaml behaviors    You will need the Microsoft Xmal Behaviours Wpf assembly and then the below xaml code will work    lt Button Content  Save  Command   Binding SaveCommand   gt     lt i Interaction Triggers gt       lt i EventTrigger EventName  Click  gt         lt i CallMethodAction MethodName  Close                             TargetObject   Binding RelativeSource  RelativeSource                                                   Mode FindAncestor                                                    AncestorType Window      gt       lt  i EventTrigger gt     lt  i Interaction Triggers gt   lt  Button gt    You don t need any code behind or anything else and can also call any other method of Window

User · Answer

As someone commented  the code I have posted is not MVVM friendly  how about the second solution   1st  not MVVM solution  I will not delete this as a reference    XAML    lt Button Name  okButton  Command   Binding OkCommand   CommandParameter   Binding RelativeSource  RelativeSource FindAncestor  AncestorType  x Type Window     gt OK lt  Button gt    ViewModel   public ICommand OkCommand       get               if   okCommand    null                         okCommand   new ActionCommand lt Window gt  DoOk  CanDoOk                     return  okCommand            void DoOk Window win           Your Code     win DialogResult   true      win Close       bool CanDoOk Window win    return true      2nd  probably better solution  Using attached behaviours  XAML   lt Button Content  Ok and Close  Command   Binding OkCommand   b CloseOnClickBehaviour IsEnabled  True    gt    View Model  public ICommand OkCommand       get   return  okCommand        Behaviour Class Something similar to this   public static class CloseOnClickBehaviour       public static readonly DependencyProperty IsEnabledProperty           DependencyProperty RegisterAttached               IsEnabled               typeof bool               typeof CloseOnClickBehaviour               new PropertyMetadata false  OnIsEnabledPropertyChanged                  public static bool GetIsEnabled DependencyObject obj                var val   obj GetValue IsEnabledProperty           return  bool val             public static void SetIsEnabled DependencyObject obj  bool value                obj SetValue IsEnabledProperty  value              static void OnIsEnabledPropertyChanged DependencyObject dpo  DependencyPropertyChangedEventArgs args                var button   dpo as Button          if  button    null              return           var oldValue    bool args OldValue          var newValue    bool args NewValue           if   oldValue  amp  amp  newValue                        button Click    OnClick                    else if  oldValue  amp  amp   newValue                        button PreviewMouseLeftButtonDown -  OnClick                       static void OnClick object sender  RoutedEventArgs e                var button   sender as Button          if  button    null              return           var win   Window GetWindow button           if  win    null              return           win Close

User · Answer

I think the most simple way has not been included already  almost   Instead of using Behaviours which adds new dependencies just use attached properties       using System      using System Windows      using System Windows Controls       public class DialogButtonManager               public static readonly DependencyProperty IsAcceptButtonProperty   DependencyProperty RegisterAttached  IsAcceptButton   typeof bool   typeof DialogButtonManager   new FrameworkPropertyMetadata OnIsAcceptButtonPropertyChanged            public static readonly DependencyProperty IsCancelButtonProperty   DependencyProperty RegisterAttached  IsCancelButton   typeof bool   typeof DialogButtonManager   new FrameworkPropertyMetadata OnIsCancelButtonPropertyChanged             public static void SetIsAcceptButton UIElement element  bool value                        element SetValue IsAcceptButtonProperty  value                      public static bool GetIsAcceptButton UIElement element                        return  bool element GetValue IsAcceptButtonProperty                      public static void SetIsCancelButton UIElement element  bool value                        element SetValue IsCancelButtonProperty  value                      public static bool GetIsCancelButton UIElement element                        return  bool element GetValue IsCancelButtonProperty                      private static void OnIsAcceptButtonPropertyChanged DependencyObject sender  DependencyPropertyChangedEventArgs e                        Button button   sender as Button               if  button    null                                if   bool e NewValue                                        SetAcceptButton button                                     else                                       ResetAcceptButton button                                                      private static void OnIsCancelButtonPropertyChanged DependencyObject sender  DependencyPropertyChangedEventArgs e                        Button button   sender as Button               if  button    null                                if   bool e NewValue                                        SetCancelButton button                                     else                                       ResetCancelButton button                                                      private static void SetAcceptButton Button button                        Window window   Window GetWindow button               button Command   new RelayCommand new Action lt object gt  ExecuteAccept                button CommandParameter   window                     private static void ResetAcceptButton Button button                        button Command   null              button CommandParameter   null                     private static void ExecuteAccept object buttonWindow                        Window window    Window buttonWindow               window DialogResult   true                     private static void SetCancelButton Button button                        Window window   Window GetWindow button               button Command   new RelayCommand new Action lt object gt  ExecuteCancel                button CommandParameter   window                     private static void ResetCancelButton Button button                        button Command   null              button CommandParameter   null                     private static void ExecuteCancel object buttonWindow                        Window window    Window buttonWindow               window DialogResult   false                    Then just set it on your dialog buttons    lt UniformGrid Grid Row  2  Grid Column  1  Rows  1  Columns  2  Margin  3   gt       lt Button Content  Accept  IsDefault  True  Padding  3  Margin  3 0 3 0  DialogButtonManager IsAcceptButton  True    gt       lt Button Content  Cancel  IsCancel  True  Padding  3  Margin  3 0 3 0  DialogButtonManager IsCancelButton  True    gt   lt  UniformGrid gt

User · Answer

I ve tried to resolve this issue in some generic  MVVM way  but I always find that I end up unnecessary complex logic  To achieve close behavior I have made an exception from the rule of no code behind and resorted to simply using good ol  events in code behind   XAML    lt Button Content  Close  Click  OnCloseClicked    gt    Code behind   private void OnCloseClicked object sender  EventArgs e        Visibility   Visibility Collapsed      Although I wish this would be better supported using commands MVVM  I simply think that there is no simpler and more clear solution than using events

User · Answer

For small apps  I use my own Application Controller for showing  closing and disposing windows and DataContexts  It s a central point in UI of an application    It s something like this     It is singleton  I will just post 2 methods and their invocations public void ShowNewWindow Window window  object dataContext   null  bool dialog   true        window DataContext   dataContext      addToWindowRegistry dataContext  window        if  dialog          window ShowDialog        else         window Show        public void CloseWindow object dataContextSender        var correspondingWindows   windowRegistry Where c   gt  c DataContext Equals dataContextSender   ToList        foreach  var pair in correspondingWindows                pair Window Close                            and their invocations from ViewModels      Show new Window with DataContext ApplicationController Instance ShowNewWindow                  new ClientCardsWindow                    new ClientCardsVM                    false       Close Current Window from viewModel ApplicationController Instance CloseWindow this     Of course you can find some restrictions in my solution  Again  I use it for small projects  and it s enough  If you re interested  I can post full code here or somewhere else

User · Answer

The solution to close a window in wpf that that worked for me is not answered here so i thought i would add my solution too           private static Window GetWindow DependencyObject sender                        Window window   null              if  sender is Window                  window    Window sender              if  window    null                  window   Window GetWindow sender               return window                    private void CloseWindow object sender  RoutedEventArgs e                        var button    Button sender as DependencyObject               Window window   GetWindow button                   if  window    null                      window Close                          window Visibility   Visibility Hidden                 choose between window close or set window visibility to close or hide the window                                            Add CloseWindow event to the button in you window as following    lt Button Content  Cancel  Click  CloseWindow   gt

User · Answer

I ve been searching for a solution to the same problem and found that doing following works fine  The solution is similar to what OP has mentioned in his question with some differences    No need of IsCancel property  Code behind should not close window  Just set DialogResult   In my case it first executes code behind and then view model command bound to the button   XAML   lt Button x Name  buttonOk  Click  Save Click  Command   Binding SaveCommand   gt OK lt  Button gt    Code Behind  private void Apply OnClick object sender  RoutedEventArgs e        this DialogResult   true      View Model  private void Save         Save data      Hope this helps

User · Answer

Simple approach is close window on saveComand Implementation  Use below code to close window  Application Current Windows 1  Close     It will close the child window

User · Answer

I also had to deal with this problem  so here my solution  It works great for me   1  Create class DelegateCommand      public class DelegateCommand lt T gt    ICommand       private Predicate lt T gt   canExecuteMethod      private readonly Action lt T gt   executeMethod      public event EventHandler CanExecuteChanged       public DelegateCommand Action lt T gt  executeMethod    this executeMethod  null                  public DelegateCommand Action lt T gt  executeMethod  Predicate lt T gt  canExecuteMethod                this  canExecuteMethod   canExecuteMethod          this  executeMethod   executeMethod    throw new ArgumentNullException nameof executeMethod    Command is not specified                  public void RaiseCanExecuteChanged                 if  this CanExecuteChanged    null              CanExecuteChanged this  null             public bool CanExecute object parameter                return  canExecuteMethod    null     canExecuteMethod  T parameter     true             public void Execute object parameter                 executeMethod  T parameter             2  Define your command          public DelegateCommand lt Window gt  CloseWindowCommand   get  private set          public MyViewModel    ctor of your viewmodel                 do something          CloseWindowCommand   new DelegateCommand lt Window gt  CloseWindow                   public void CloseWindow Window win     this method is also in your viewmodel                 do something         win  Close            3  Bind your command in the view  public MyView Window win    ctor of your view  window as parameter               InitializeComponent            MyButton CommandParameter   win          MyButton Command     MyViewModel this DataContext  CloseWindowCommand          4  And now the window     Window win   new Window                         Title    My Window               Height   800              Width   800              WindowStartupLocation   WindowStartupLocation CenterScreen                      win Content   new MyView win           win ShowDialog      so thats it  you can also bind the command in the xaml file and find the window with FindAncestor and bind it to the command parameter

User · Answer

I d personally use a behaviour to do this sort of thing   public class WindowCloseBehaviour   Behavior lt Window gt        public static readonly DependencyProperty CommandProperty         DependencyProperty Register           Command           typeof ICommand           typeof WindowCloseBehaviour         public static readonly DependencyProperty CommandParameterProperty         DependencyProperty Register           CommandParameter           typeof object           typeof WindowCloseBehaviour         public static readonly DependencyProperty CloseButtonProperty         DependencyProperty Register           CloseButton           typeof Button           typeof WindowCloseBehaviour           new FrameworkPropertyMetadata null  OnButtonChanged         public ICommand Command               get   return  ICommand GetValue CommandProperty             set   SetValue CommandProperty  value                public object CommandParameter               get   return GetValue CommandParameterProperty             set   SetValue CommandParameterProperty  value                public Button CloseButton               get   return  Button GetValue CloseButtonProperty             set   SetValue CloseButtonProperty  value                private static void OnButtonChanged DependencyObject d  DependencyPropertyChangedEventArgs e                var window    Window   WindowCloseBehaviour d  AssociatedObject            Button  e NewValue  Click                 s  e1    gt                                var command     WindowCloseBehaviour d  Command                  var commandParameter     WindowCloseBehaviour d  CommandParameter                  if  command    null                                        command Execute commandParameter                                                                                           window Close                                     You can then attach this to your Window and Button to do the work    lt Window x Class  WpfApplication6 Window1          xmlns  http   schemas microsoft com winfx 2006 xaml presentation          xmlns x  http   schemas microsoft com winfx 2006 xaml          xmlns i  http   schemas microsoft com expression 2010 interactivity          xmlns local  clr-namespace WpfApplication6          Title  Window1  Height  300  Width  300  gt       lt i Interaction Behaviors gt           lt local WindowCloseBehaviour CloseButton   Binding ElementName closeButton    gt       lt  i Interaction Behaviors gt       lt Grid gt           lt Button Name  closeButton  gt Close lt  Button gt       lt  Grid gt   lt  Window gt    I ve added Command and CommandParameter here so you can run a command before the Window closes

User · Answer

I use the Publish Subscribe pattern for complicated class-dependencies   ViewModel       public class ViewModel   ViewModelBase               public ViewModel                         CloseComand   new DelegateCommand  obj    gt                                        MessageBus Instance Publish Messages REQUEST DEPLOYMENT SETTINGS CLOSED  null                                     Window   public partial class SomeWindow   Window       Subscription  subscription   new Subscription         public SomeWindow                 InitializeComponent              subscription Subscribe Messages REQUEST DEPLOYMENT SETTINGS CLOSED  obj   gt                                this Close                              You can leverage Bizmonger Patterns to get the MessageBus   MessageBus  public class MessageBus        region Singleton     static MessageBus  messageBus   null      private MessageBus            public static MessageBus Instance               get                       if   messageBus    null                                 messageBus   new MessageBus                               return  messageBus                       endregion       region Members     List lt Observer gt   observers   new List lt Observer gt         List lt Observer gt   oneTimeObservers   new List lt Observer gt         List lt Observer gt   waitingSubscribers   new List lt Observer gt         List lt Observer gt   waitingUnsubscribers   new List lt Observer gt          int  publishingCount   0       endregion      public void Subscribe string message  Action lt object gt  response                Subscribe message  response   observers              public void SubscribeFirstPublication string message  Action lt object gt  response                Subscribe message  response   oneTimeObservers              public int Unsubscribe string message  Action lt object gt  response                var observers   new List lt Observer gt   observers Where o   gt  o Respond    response  ToList             observers AddRange  waitingSubscribers Where o   gt  o Respond    response            observers AddRange  oneTimeObservers Where o   gt  o Respond    response             if   publishingCount    0                        observers ForEach o   gt   observers Remove o                       else                        waitingUnsubscribers AddRange observers                      return observers Count             public int Unsubscribe string subscription                var observers   new List lt Observer gt   observers Where o   gt  o Subscription    subscription  ToList             observers AddRange  waitingSubscribers Where o   gt  o Subscription    subscription            observers AddRange  oneTimeObservers Where o   gt  o Subscription    subscription             if   publishingCount    0                        observers ForEach o   gt   observers Remove o                       else                        waitingUnsubscribers AddRange observers                      return observers Count             public void Publish string message  object payload                 publishingCount             Publish  observers  message  payload           Publish  oneTimeObservers  message  payload           Publish  waitingSubscribers  message  payload             oneTimeObservers RemoveAll o   gt  o Subscription    message            waitingUnsubscribers Clear              publishingCount--             private void Publish List lt Observer gt  observers  string message  object payload                Debug Assert  publishingCount  gt   0            var subscribers   observers Where o   gt  o Subscription ToLower      message ToLower              foreach  var subscriber in subscribers                        subscriber Respond payload                        public IEnumerable lt Observer gt  GetObservers string subscription                var observers   new List lt Observer gt   observers Where o   gt  o Subscription    subscription            return observers             public void Clear                  observers Clear             oneTimeObservers Clear                region Helpers     private void Subscribe string message  Action lt object gt  response  List lt Observer gt  observers                Debug Assert  publishingCount  gt   0            var observer   new Observer     Subscription   message  Respond   response             if   publishingCount    0                        observers Add observer                     else                        waitingSubscribers Add observer                        endregion        Subscription  public class Subscription        region Members     List lt Observer gt   observerList   new List lt Observer gt          endregion      public void Unsubscribe string subscription                var observers    observerList Where o   gt  o Subscription    subscription            foreach  var observer in observers                        MessageBus Instance Unsubscribe observer Subscription  observer Respond                       observerList Where o   gt  o Subscription    subscription  ToList   ForEach o   gt   observerList Remove o               public void Subscribe string subscription  Action lt object gt  response                MessageBus Instance Subscribe subscription  response            observerList Add new Observer     Subscription   subscription  Respond   response                public void SubscribeFirstPublication string subscription  Action lt object gt  response                MessageBus Instance SubscribeFirstPublication subscription  response

User · Answer

There is a useful behavior for this task which doesn t break MVVM  a Behavior  introduced with Expression Blend 3  to allow the View to hook into commands defined completely within the ViewModel        This behavior demonstrates a simple technique for allowing the   ViewModel to manage the closing events of the View in a   Model-View-ViewModel application         This allows you to hook up a behavior in your View  UserControl  which   will provide control over the control s Window  allowing the ViewModel   to control whether the window can be closed via standard ICommands       Using Behaviors to Allow the ViewModel to Manage View Lifetime in M-V-VM      http   gallery expression microsoft com WindowCloseBehavior    Above link has been archived to http   code msdn microsoft com Window-Close-Attached-fef26a66 content

User · Answer

You can do it without code behind  Create command  in Execute method call  Save  method on viewmodel and after that call close method on edit window  which you can pass to the command by parameter   public void Execute object parameter         mainViewModel SaveSomething        var editWindow   parameter as MyEditWindow      editWindow  Close        Save amp Close button XAML    lt Button Content Save amp Close  Command   Binding SaveCmd   CommandParameter   Binding RelativeSource  RelativeSource FindAncestor  AncestorType Window     IsDefault  True    gt

User · Answer

I found myself having to do this on a WPF application based on  Net Core 3 0  where unfortunately behaviour support was not yet officially available in the Microsoft Xaml Behaviors Wpf NuGet package   Instead  I went with a solution that made use of the Fa  ade design pattern   Interface   public interface IWindowFacade       void Close        Window   public partial class MainWindow   Window  IWindowFacade       Standard command property on the view model   public ICommand ExitCommand       Control binding    lt MenuItem Header  E xit  Command   Binding ExitCommand   CommandParameter   Binding RelativeSource  RelativeSource AncestorType Window     gt    Command   public class ExitCommand   ICommand               public void Execute object parameter                var windowFacade   parameter as IWindowFacade          windowFacade  Close                      Because the Close   method is already implemented by the Window class  applying the fa  ade interface to the window is the only required code behind in the UI layer  for this simple example    The command in the presentation layer avoids any dependencies on the view UI layer as it has no idea what it is talking to when it calls the Close method on the fa  ade

User · Answer

I just completed a blog post on this very topic   In a nutshell  add an Action property to your ViewModel with get and set accessors   Then define the Action from your View constructor   Finally  invoke your action in the bound command that should close the window   In the ViewModel   public Action CloseAction    get  set     and in the View constructor   private View         InitializeComponent        ViewModel vm   new ViewModel        this DataContext   vm      if   vm CloseAction    null           vm CloseAction   new Action this Close       Finally  in whatever bound command that should close the window  we can simply invoke  CloseAction       Calls Close   method of the View   This worked for me  seemed like a fairly elegant solution  and saved me a bunch of coding

[c#] WPF MVVM: How to close a window

Examples related to c#

Examples related to .net

Examples related to wpf

Examples related to xaml

Examples related to mvvm