Simple bubble sort c

Question

int   arr    800 11 50 771 649 770 240  9    int temp   0   for  int write   0  write  lt  arr Length  write          for  int sort   0  sort  lt  arr Length - 1  sort                  if  arr sort   gt  arr sort   1                         temp   arr sort   1               arr sort   1    arr sort               arr sort    temp                                Console Write   0     arr write          All I am attempting to do is a simple bubble sort with this array  I would like to figure out why the sorting is screwed up  In example  here is when the array is  800 11 50 771 649 770 240  9    Here is what gets displayed   11  50  649  9  649  770  771  800   I am thinking that I might be missing something in the comparison

User · Answer

static bool BubbleSort ref List lt int gt  myList  int number                if  number    1              return true          for  int i   0  i  lt  number  i                          if   i   1  lt  number   amp  amp   myList i   gt  myList i   1                                  int temp   myList i                   myList i    myList i   1                   myList i   1    temp                            else                 continue                    return BubbleSort ref myList  number - 1

User · Answer

using System    using System Collections Generic    using System Linq    using System Text    using System Threading Tasks   namespace Practice       class Program               static void Main string   args                        Console WriteLine  Enter the size                int n   Convert ToInt32 Console ReadLine                 int   mynum   new int n               Console WriteLine  Enter the Numbers                for  int p   0  p  lt  n p                                   mynum p    Convert ToInt32 Console ReadLine                                Console WriteLine  The number are                    foreach int p in mynum                                        Console WriteLine p                                     for  int i   0  i  lt  n i                                           for int j i 1 j lt n j                                                  if mynum i  gt mynum j                                                         int x   mynum j                               mynum j    mynum i                               mynum i    x                                                                                    Console WriteLine  Sortrd data is-                foreach int p in mynum                                Console WriteLine p                                     Console ReadLine

User · Answer

It does the same in a more elegant way   var arrayValues   new     99  12  11  300  400  10  9  3  6  5  7  8   for  var mainLoop   0  mainLoop  lt  arrayValues Length  mainLoop         for  var innerLoop   mainLoop   1  innerLoop  lt  arrayValues Length  innerLoop                if  arrayValues mainLoop   lt   arrayValues innerLoop                     continue                   var temp   arrayValues mainLoop          arrayValues mainLoop    arrayValues innerLoop          arrayValues innerLoop    temp

User · Answer

I wanted to add to the accepted answer something different  Number of iterations can be reduced as well  as below   int   arr     800  11  50  771  649  770  240  9     int temp   0  int arrLength   arr Length   for  int write   0  write  lt  arr Length - 1  write    arrLength--        for  int sort   0  sort  lt  arrLength - 1  sort                  if  arr sort   gt  arr sort   1                         temp   arr sort   1               arr sort   1    arr sort               arr sort    temp                     foreach  var item in arr        Console WriteLine item

User · Answer

Bubble sort with sort direction -  using System   public class Program       public static void Main string   args                var input   new     800  11  50  771  649  770  240  9             BubbleSort input            Array ForEach input  Console WriteLine            Console ReadKey               public enum Direction               Ascending   0          Descending            public static void BubbleSort int   input  Direction direction   Direction Ascending                bool swapped          var length   input Length           do                       swapped   false              for  var index   0  index  lt  length - 1  index                                  var needSwap   direction    Direction Ascending   input index   gt  input index   1    input index   lt  input index   1                    if  needSwap                                        var temp   input index                       input index    input index   1                       input index   1    temp                      swapped   true                                            while  swapped

User · Answer

I saw someone use this example as part of a job application test  My feedback to him was that it lacks an escape from the outer loop when the array is mostly sorted   consider what would happen in this case   int   arr    1 2 3 4 5 6 7 8     here s something that makes more sense   int   arr    1 2 3 4 5 6 7 8    int temp   0  int loopCount 0  bool doBreak true   for  int write   0  write  lt  arr Length  write          doBreak true      for  int sort   0  sort  lt  arr Length - 1  sort                  if  arr sort   gt  arr sort   1                         temp   arr sort   1               arr sort   1    arr sort               arr sort    temp              doBreak false                    loopCount              if doBreak   break    early escape        Console WriteLine loopCount   for  int i   0  i  lt  arr Length  i    Console Write arr i

User · Answer

int   array   new int 10    13  2  5  8  23  90  41  4  77  61     for  int i   10  i  gt  0  i--        for  int j   0  j  lt  9  j                  if  array j   gt  array j   1                         int temp   array j               array j    array j   1               array j   1    temp

User · Answer

This one works for me   public static int   SortArray int   array        int length   array Length       int temp   array 0        for  int i   0  i  lt  length  i                  for  int j   i 1  j  lt  length  j                          if  array i   gt  array j                                 temp   array i                    array i    array j                    array j    temp                                     return array

User · Answer

int   arr     800  11  50  771  649  770  240  9     int temp   0   for  int write   0  write  lt  arr Length  write          for  int sort   0  sort  lt  arr Length - 1 - write   sort                  if  arr sort   gt  arr sort   1                         temp   arr sort   1               arr sort   1    arr sort               arr sort    temp                     for  int i   0  i  lt  arr Length  i    Console Write arr i           Console ReadKey

User · Answer

No  your algorithm works but your Write operation is misplaced within the outer loop    int   arr     800  11  50  771  649  770  240  9     int temp   0   for  int write   0  write  lt  arr Length  write          for  int sort   0  sort  lt  arr Length - 1  sort              if  arr sort   gt  arr sort   1                 temp   arr sort   1               arr sort   1    arr sort               arr sort    temp                     for  int i   0  i  lt  arr Length  i        Console Write arr i           Console ReadKey

User · Answer

int   arr     800  11  50  771  649  770  240  9    for  int i   0  i  lt  arr Length  i          for  int j   i  j  lt  arr Length   j                  if  arr j   lt  arr i                         int temp   arr i               arr i    arr j               arr j    temp                    Console ReadLine

User · Answer

public void BubbleSortNum                 int   a    10 5 30 25 40 20           int length   a Length          int temp   0           for  int i   0  i  lt length  i                                         for int j i j lt length  j                                  if  a i  gt a j                                         temp   a j                       a j    a i                       a i    temp                                                  Console WriteLine a i

User · Answer

Just another example but with an outter WHILE loop instead of a FOR   public static void Bubble                 int   data     5  4  3  2  1            bool newLoopNeeded   false          int temp          int loop   0           while   newLoopNeeded                        newLoopNeeded   true              for  int i   0  i  lt  data Length - 1  i                                  if  data i   1   lt  data i                                         temp   data i                       data i    data i   1                       data i   1    temp                      newLoopNeeded   false                                    loop

User · Answer

This is what I wrote using recursive methods       public static int   BubbleSort int   input                bool isSorted   true          for  int i   0  i  lt  input Length  i                          if  i    input Length - 1  amp  amp  input i   gt  input i   1                                 isSorted   false                  int temp   input i                   input i    input i   1                   input i   1    temp                                  return isSorted   input   BubbleSort input

User · Answer

public static void BubbleSort int   a                for  int i   1  i  lt   a Length - 1    i               for  int j   0  j  lt  a Length - i    j                   if  a j   gt  a j   1                         Swap ref a j   ref a j   1                public static void Swap ref int x  ref int y                int temp   x          x   y          y   temp

User · Answer

public static int   BubbleSort int   arr       int length   arr Length        while  length  gt  0             int newLength   0        for  int i   1  i  lt  length  i                     if  arr i - 1   gt  arr i                          Swap ref arr i - 1   ref arr i                 newLength   i                                 length   newLength          public static void Swap ref int x  ref int y       int temp   y     y   x     x   temp

User · Answer

Your Console Write   0     arr write    is too early  You re printing the values while the sort is still in progress  For example  you re printing 9 as being index 3 in the array  yet on the very next iteration of the loop the 9 has moved to index 2 and 240 has moved to index 3    yet you re outer loop has moved forward so it prints 649 the second time and 240 never gets printed

[c#] Simple bubble sort c#

Examples related to c#

Examples related to arrays

Examples related to sorting

Examples related to bubble-sort