Why I m getting Non-static method should not be called statically when invoking a method in a Eloquent model

Question

Im trying to load my model in my controller and tried this   return Post  getAll      got the error Non-static method Post  getAll   should not be called statically  assuming  this from incompatible context  The function in the model looks like this   public function getAll          return  posts    this- gt all  - gt take 2 - gt get         What s the correct way to load the model in a controller and then return it s contents

User · Answer

You can give like this  public static function getAll          return  posts    this- gt all  - gt take 2 - gt get         And when you call statically inside your controller function also

User · Answer

Solution to the original question You called a non-static method statically  To make a public function static in the model  would look like this  public static function         In General  Post  get    In this particular instance  Post  take 2 - gt get    One thing to be careful of  when defining relationships and scope  that I had an issue with that caused a  non-static method should not be called statically  error is when they are named the same  for example  public function category        return  this- gt belongsTo  App Category       public function scopeCategory        return  query- gt where  category   1      When I do the following  I get the non-static error  Event  category  - gt get     The issue  is that Laravel is using my relationship method called category  rather than my category scope  scopeCategory   This can be resolved by renaming the scope or the relationship  I chose to rename the relationship  public function cat        return  this- gt belongsTo  App Category    category id       Please observe that I defined the foreign key  category id  because otherwise Laravel would have looked for cat id instead  and it wouldn t have found it  as I had defined it as category id in the database

User · Answer

Check if you do not have declared the method getAll   in the model  That causes the controller to think that you are calling a non-static method

User · Answer

TL DR  You can get around this by expressing your queries as MyModel  query  - gt find 10   instead of MyModel  find 10     To the best of my knowledge  starting PhpStorm 2017 2 code inspection fails for methods such as MyModel  where    MyModel  find    etc  check this thread   This could get quite annoying  when you try let s say to use PhpStorm s Git integration before committing your code  PhpStorm won t stop complaining about these static method call warnings   One elegant way  IMOO  to get around this is to explicitly call   query   wherever it makes sense to  This will let you benefit from a free auto-completion and a nice query formatting   Examples  Snippet where inspection complains about static method calls   myModel   MyModel  find 10      static call complaint     another poorly formatted query with code inspection complaints  myFilteredModels   MyModel  where  is beautiful   true      - gt where  is not smart   false      - gt get      Well formatted code with no complaints   myModel   MyModel  query  - gt find 10       a nicely formatted query with no complaints  myFilteredModels   MyModel  query       - gt where  is beautiful   true      - gt where  is not smart   false      - gt get

User · Answer

I ve literally just arrived at the answer in my case  I m creating a system that has implemented a create method  so I was getting this actual error because I was accessing the overridden version not the one from Eloquent   Hope that help

User · Answer

Why not try adding Scope  Scope is a very good feature of Eloquent   class User extends Eloquent        public function scopePopular  query                return  query- gt where  votes     gt    100              public function scopeWomen  query                return  query- gt whereGender  W               users   User  popular  - gt women  - gt orderBy  created at  - gt get      Eloquent  scopes in Laravel Docs

User · Answer

You defined your method as non-static and you are trying to invoke it as static  That said       1 if you want to invoke a static method  you should use the    and define your method as static      Defining a static method in a Foo class  public static function getAll        code          Invoking that static method Foo  getAll      2 otherwise  if you want to invoke an instance method you should instance your class  use - gt       Defining a non-static method in a Foo class  public function getAll        code          Invoking that non-static method   foo   new Foo     foo- gt getAll      Note  In Laravel  almost all Eloquent methods return an instance of your model  allowing you to chain methods as shown below    foos   Foo  all  - gt take 10 - gt get      In that code we are statically calling the all method via Facade  After that  all other methods are being called as instance methods

User · Answer

For use the syntax like return Post  getAll    you should have a magic function   callStatic in your class where handle all static calls   public static function   callStatic  method   parameters        return  new static - gt  method     parameters

User · Answer

Just in case this helps someone  I was getting this error because I completely missed the stated fact that the scope prefix must not be used when calling a local scope  So if you defined a local scope in your model like this   public function scopeRecentFirst  query        return  query- gt orderBy  updated at    desc        You should call it like    CurrentUsers    App Models Users  recentFirst  - gt get      Note that the prefix scope is not present in the call

[php] Why I'm getting 'Non-static method should not be called statically' when invoking a method in a Eloquent model?

Examples related to php

Examples related to laravel

Examples related to eloquent