Signed to unsigned conversion in C - is it always safe

Question

Suppose I have the following C code   unsigned int u   1234  int i   -5678   unsigned int result   u   i    What implicit conversions are going on here  and is this code safe for all values of u and i   Safe  in the sense that even though result in this example will overflow to some huge positive number  I could cast it back to an int and get the real result

User · Answer

When one unsigned and one signed variable are added (or any binary operation) both are implicitly converted to unsigned, which would in this case result in a huge result.

So it is safe in the sense of that the result might be huge and wrong, but it will never crash.

User · Answer

Referring to the bible    Your addition operation causes the int to be converted to an unsigned int  Assuming two s complement representation and equally sized types  the bit pattern does not change  Conversion from unsigned int to signed int is implementation dependent   But it probably works the way you expect on most platforms these days   The rules are a little more complicated in the case of combining signed and unsigned of differing sizes

User · Answer

Short Answer  Your i will be converted to an unsigned integer by adding UINT MAX   1  then the addition will be carried out with the unsigned values  resulting in a large result  depending on the values of u and i    Long Answer  According to the C99 Standard      6 3 1 8 Usual arithmetic conversions         If both operands have the same type  then no further conversion is needed    Otherwise  if both operands have signed integer types or both have unsigned integer types  the operand with the type of lesser integer conversion rank is converted to the type of the operand with greater rank    Otherwise  if the operand that has unsigned integer type has rank greater or equal to the rank of the type of the other operand  then the operand with signed integer type is converted to the type of the operand with unsigned integer type    Otherwise  if the type of the operand with signed integer type can represent all of the values of the type of the operand with unsigned integer type  then the operand with unsigned integer type is converted to the type of the operand with signed integer type    Otherwise  both operands are converted to the unsigned integer type corresponding to the type of the operand with signed integer type       In your case  we have one unsigned int  u  and signed int  i   Referring to  3  above  since both operands have the same rank  your i will need to be converted to an unsigned integer      6 3 1 3 Signed and unsigned integers         When a value with integer type is converted to another integer type other than  Bool  if the value can be represented by the new type  it is unchanged    Otherwise  if the new type is unsigned  the value is converted by repeatedly adding or subtracting one more than the maximum value that can be represented in the new type until the value is in the range of the new type    Otherwise  the new type is signed and the value cannot be represented in it  either the result is implementation-defined or an implementation-defined signal is raised       Now we need to refer to  2  above  Your i will be converted to an unsigned value by adding UINT MAX   1  So the result will depend on how UINT MAX is defined on your implementation  It will be large  but it will not overflow  because      6 2 5  9       A computation involving unsigned operands can never overflow  because a result that cannot be represented by the resulting unsigned integer type is reduced modulo the number that is one greater than the largest value that can be represented by the resulting type    Bonus  Arithmetic Conversion Semi-WTF   include  lt stdio h gt   int main void      unsigned int plus one   1    int minus one   -1     if plus one  lt  minus one      printf  1  lt  -1      else     printf  boring       return 0      You can use this link to try this online  https   repl it repls QuickWhimsicalBytes  Bonus  Arithmetic Conversion Side Effect  Arithmetic conversion rules can be used to get the value of UINT MAX by initializing an unsigned value to -1  ie   unsigned int umax   -1     umax set to UINT MAX   This is guaranteed to be portable regardless of the signed number representation of the system because of the conversion rules described above  See this SO question for more information  Is it safe to use -1 to set all bits to true

User · Answer

As was previously answered  you can cast back and forth between signed and unsigned without a problem  The border case for signed integers is -1   0xFFFFFFFF   Try adding and subtracting from that and you ll find that you can cast back and have it be correct   However  if you are going to be casting back and forth  I would strongly advise naming your variables such that it is clear what type they are  eg   int iValue  iResult  unsigned int uValue  uResult    It is far too easy to get distracted by more important issues and forget which variable is what type if they are named without a hint  You don t want to cast to an unsigned and then use that as an array index

User · Answer

When converting from signed to unsigned there are two possibilities  Numbers that were originally positive remain  or are interpreted as  the same value  Number that were originally negative will now be interpreted as larger positive numbers

User · Answer

What implicit conversions are going on here     i will be converted to an unsigned integer      and is this code safe for all values of u and i    Safe in the sense of being well-defined yes  see https   stackoverflow com a 50632 5083516      The rules are written in typically hard to read standards-speak but essentially whatever representation was used in the signed integer the unsigned integer will contain a 2 s complement representation of the number    Addition  subtraction and multiplication will work correctly on these numbers resulting in another unsigned integer containing a twos complement number representing the  real result     division and casting to larger unsigned integer types will have well-defined results but those results will not be 2 s complement representations of the  real result        Safe  in the sense that even though result in this example will overflow to some huge positive number  I could cast it back to an int and get the real result     While conversions from signed to unsigned are defined by the standard the reverse is implementation-defined both gcc and msvc define the conversion such that you will get the  real result  when converting a 2 s complement number stored in an unsigned integer back to a signed integer  I expect you will only find any other behaviour on obscure systems that don t use 2 s complement for signed integers   https   gcc gnu org onlinedocs gcc Integers-implementation html Integers-implementation https   msdn microsoft com en-us library 0eex498h aspx

User · Answer

Conversion from signed to unsigned does not necessarily just copy or reinterpret the representation of the signed value   Quoting the C standard  C99 6 3 1 3       When a value with integer type is converted to another integer type other than  Bool  if   the value can be represented by the new type  it is unchanged       Otherwise  if the new type is unsigned  the value is converted by repeatedly adding or   subtracting one more than the maximum value that can be represented in the new type   until the value is in the range of the new type       Otherwise  the new type is signed and the value cannot be represented in it  either the   result is implementation-defined or an implementation-defined signal is raised    For the two s complement representation that s nearly universal these days  the rules do correspond to reinterpreting the bits   But for other representations  sign-and-magnitude or ones  complement   the C implementation must still arrange for the same result  which means that the conversion can t just copy the bits   For example   unsigned -1    UINT MAX  regardless of the representation   In general  conversions in C are defined to operate on values  not on representations   To answer the original question   unsigned int u   1234  int i   -5678   unsigned int result   u   i    The value of i is converted to unsigned int  yielding UINT MAX   1 - 5678   This value is then added to the unsigned value 1234  yielding UINT MAX   1 - 4444    Unlike unsigned overflow  signed overflow invokes undefined behavior   Wraparound is common  but is not guaranteed by the C standard -- and compiler optimizations can wreak havoc on code that makes unwarranted assumptions

User · Answer

Horrible Answers Galore  Ozgur Ozcitak     When you cast from signed to unsigned    and vice versa  the internal   representation of the number does not   change  What changes is how the   compiler interprets the sign bit    This is completely wrong   Mats Fredriksson     When one unsigned and one signed   variable are added  or any binary   operation  both are implicitly   converted to unsigned  which would in   this case result in a huge result    This is also wrong  Unsigned ints may be promoted to ints should they have equal precision due to padding bits in the unsigned type   smh     Your addition operation causes the int   to be converted to an unsigned int    Wrong  Maybe it does and maybe it doesn t      Conversion from unsigned int to signed   int is implementation dependent   But   it probably works the way you expect   on most platforms these days     Wrong  It is either undefined behavior if it causes overflow or the value is preserved   Anonymous     The value of i is converted to   unsigned int       Wrong  Depends on the precision of an int relative to an unsigned int   Taylor Price     As was previously answered  you can   cast back and forth between signed and   unsigned without a problem    Wrong  Trying to store a value outside the range of a signed integer results in undefined behavior   Now I can finally answer the question   Should the precision of int be equal to unsigned int  u will be promoted to a signed int and you will get the value -4444 from the expression  u i   Now  should u and i have other values  you may get overflow and undefined behavior but with those exact numbers you will get -4444  1   This value will have type int  But you are trying to store that value into an unsigned int so that will then be cast to an unsigned int and the value that result will end up having would be  UINT MAX 1  - 4444   Should the precision of unsigned int be greater than that of an int  the signed int will be promoted to an unsigned int yielding the value  UINT MAX 1  - 5678 which will be added to the other unsigned int 1234  Should u and i have other values  which make the expression fall outside the range  0  UINT MAX  the value  UINT MAX 1  will either be added or subtracted until the result DOES fall inside the range  0  UINT MAX  and no undefined behavior will occur   What is precision   Integers have padding bits  sign bits  and value bits  Unsigned integers do not have a sign bit obviously  Unsigned char is further guaranteed to not have padding bits  The number of values bits an integer has is how much precision it has    Gotchas   The macro sizeof macro alone cannot be used to determine precision of an integer if padding bits are present  And the size of a byte does not have to be an octet  eight bits  as defined by C99    1  The overflow may occur at one of two points  Either before the addition  during promotion  - when you have an unsigned int which is too large to fit inside an int  The overflow may also occur after the addition even if the unsigned int was within the range of an int  after the addition the result may still overflow

[c] Signed to unsigned conversion in C - is it always safe?

Examples related to c

Examples related to type-conversion