java lang IllegalStateException Can not perform this action after onSaveInstanceState

Question

I m using the support library for my app  In my FragmentActivity I m using an AsyncTask for downloading data from internet  In the onPreExecute   method I add a Fragment and in the onPostExecute   method I remove it again  When the orientation is changed in between  I get the above mentioned exception  Please take a look at the details   private class onFriendAddedAsyncTask extends AsyncTask lt String  Void  String gt        DummyFragment dummyFragment       FragmentManager fm      FragmentTransaction ft    Override protected void onPreExecute         Log v  MyFragmentActivity    onFriendAddedAsyncTask onPreExecute        dummyFragment   DummyFragment newInstance        fm   getSupportFragmentManager        ft   fm beginTransaction        ft add dummyFragment   dummy fragment        ft commit        Override protected void onPostExecute String result        Log v  MyFragmentActivity    onFriendAddedAsyncTask onPostExecute        ft   fm beginTransaction        ft remove dummyFragment       ft commit        Override protected String doInBackground String    name        Log v  MyFragmentActivity    onFriendAddedAsyncTask doInBackground                I get following LogCut   01-05 23 54 19 958  V MyFragmentActivity 12783   onFriendAddedAsyncTask onPreExecute 01-05 23 54 19 968  V DummyFragment 12783   onAttach 01-05 23 54 19 968  V DummyFragment 12783   onCreate 01-05 23 54 19 968  V MyFragmentActivity 12783   onFriendAddedAsyncTask doInBackground 01-05 23 54 19 973  V DummyFragment 12783   onCreateView 01-05 23 54 19 973  V DummyFragment 12783   onActivityCreated 01-05 23 54 19 973  V DummyFragment 12783   onStart 01-05 23 54 19 973  V DummyFragment 12783   onResume 01-05 23 54 21 933  V MyFragmentActivity 12783   onSaveInstanceState 01-05 23 54 21 933  V DummyFragment 12783   onSaveInstanceState 01-05 23 54 21 933  V MyFragmentActivity 12783   onPause 01-05 23 54 21 933  V DummyFragment 12783   onPause 01-05 23 54 21 938  V MyFragmentActivity 12783   onStop 01-05 23 54 21 938  V DummyFragment 12783   onStop 01-05 23 54 21 938  V MyFragmentActivity 12783   onDestroy 01-05 23 54 21 938  V DummyFragment 12783   onDestroyView 01-05 23 54 21 938  V DummyFragment 12783   onDestroy 01-05 23 54 21 938  V DummyFragment 12783   onDetach 01-05 23 54 21 978  V MyFragmentActivity 12783   onCreate 01-05 23 54 21 978  V DummyFragment 12783   onAttach 01-05 23 54 21 978  V DummyFragment 12783   onCreate 01-05 23 54 22 263  V MyFragmentActivity 12783   onStart 01-05 23 54 22 313  V DummyFragment 12783   onCreateView 01-05 23 54 22 313  V DummyFragment 12783   onActivityCreated 01-05 23 54 22 313  V DummyFragment 12783   onStart 01-05 23 54 22 323  V MyFragmentActivity 12783   onResume 01-05 23 54 22 323  V MyFragmentActivity 12783   onPostResume 01-05 23 54 22 323  V MyFragmentActivity 12783   onResumeFragments 01-05 23 54 22 323  V DummyFragment 12783   onResume 01-05 23 54 27 123  V MyFragmentActivity 12783   onFriendAddedAsyncTask onPostExecute 01-05 23 54 27 123  D AndroidRuntime 12783   Shutting down VM 01-05 23 54 27 123  W dalvikvm 12783   threadid 1  thread exiting with uncaught exception  group 0x4001d7d0  01-05 23 54 27 138  E AndroidRuntime 12783   FATAL EXCEPTION  main 01-05 23 54 27 138  E AndroidRuntime 12783   java lang IllegalStateException  Can not perform this action after onSaveInstanceState 01-05 23 54 27 138  E AndroidRuntime 12783      at android support v4 app FragmentManagerImpl checkStateLoss FragmentManager java 1314  01-05 23 54 27 138  E AndroidRuntime 12783      at android support v4 app FragmentManagerImpl enqueueAction FragmentManager java 1325  01-05 23 54 27 138  E AndroidRuntime 12783      at android support v4 app BackStackRecord commitInternal BackStackRecord java 548  01-05 23 54 27 138  E AndroidRuntime 12783      at android support v4 app BackStackRecord commit BackStackRecord java 532  01-05 23 54 27 138  E AndroidRuntime 12783      at com xyz dummy MyFragmentActivity onFriendAddedAsyncTask onPostExecute MyFragmentActivity java 447  01-05 23 54 27 138  E AndroidRuntime 12783      at com xyz dummy MyFragmentActivity onFriendAddedAsyncTask onPostExecute MyFragmentActivity java 1  01-05 23 54 27 138  E AndroidRuntime 12783      at android os AsyncTask finish AsyncTask java 417  01-05 23 54 27 138  E AndroidRuntime 12783      at android os AsyncTask access 300 AsyncTask java 127  01-05 23 54 27 138  E AndroidRuntime 12783      at android os AsyncTask InternalHandler handleMessage AsyncTask java 429  01-05 23 54 27 138  E AndroidRuntime 12783      at android os Handler dispatchMessage Handler java 99  01-05 23 54 27 138  E AndroidRuntime 12783      at android os Looper loop Looper java 123  01-05 23 54 27 138  E AndroidRuntime 12783      at android app ActivityThread main ActivityThread java 4627  01-05 23 54 27 138  E AndroidRuntime 12783      at java lang reflect Method invokeNative Native Method  01-05 23 54 27 138  E AndroidRuntime 12783      at java lang reflect Method invoke Method java 521  01-05 23 54 27 138  E AndroidRuntime 12783      at com android internal os ZygoteInit MethodAndArgsCaller run ZygoteInit java 858  01-05 23 54 27 138  E AndroidRuntime 12783      at com android internal os ZygoteInit main ZygoteInit java 616  01-05 23 54 27 138  E AndroidRuntime 12783      at dalvik system NativeStart main Native Method    In other threads about similar problems the reason seems to be that the onPostExecute method is called before the onResume   method is called  But I get the exception even though onResume   is called before   Does someone knows what s wrong   The Activity looks like this   public class MyFragmentActivity extends FragmentActivity implements OnFriendSelectedListener  OnFriendAddedListener  OnFriendOptionSelectedListener  LoaderCallbacks lt Cursor gt      Override public void onCreate Bundle savedInstanceState        Log v  MyFragmentActivity    onCreate        super onCreate savedInstanceState       setContentView R layout fragment activity layout       FragmentManager fm   getSupportFragmentManager        FragmentTransaction ft   fm beginTransaction        FriendListFragment friendListFragment    FriendListFragment fm findFragmentById R id friend list fragment layout       if  friendListFragment    null            friendListFragment   new FriendListFragment             ft add R id friend list fragment layout  friendListFragment           ft commit            fm executePendingTransactions            startService new Intent this  MyIntentService class            getSupportLoaderManager   initLoader CHECK EMPTY DATABASE  null  this                 Override public boolean onCreateOptionsMenu Menu menu        super onCreateOptionsMenu menu       getMenuInflater   inflate R menu fragment activity options menu  menu       return true      Override public boolean onOptionsItemSelected MenuItem item        super onOptionsItemSelected item       switch  item getItemId          case R id add friend menu item          AddFriendDialogFragment addFriendDialogFragment   AddFriendDialogFragment newInstance            addFriendDialogFragment show getSupportFragmentManager     add friend dialog fragment            return true      default          return false            Override public void onFriendAdded String name        name   name trim        if  name length    gt  0            new onFriendAddedAsyncTask   execute name             When using commitAllowingStateLoss   I get the following exception   01-06 14 54 29 548  E AndroidRuntime 18020   FATAL EXCEPTION  main 01-06 14 54 29 548  E AndroidRuntime 18020   java lang IllegalStateException  Activity has been destroyed 01-06 14 54 29 548  E AndroidRuntime 18020      at android support v4 app FragmentManagerImpl enqueueAction FragmentManager java 1329  01-06 14 54 29 548  E AndroidRuntime 18020      at android support v4 app BackStackRecord commitInternal BackStackRecord java 548  01-06 14 54 29 548  E AndroidRuntime 18020      at android support v4 app BackStackRecord commitAllowingStateLoss BackStackRecord java 536  01-06 14 54 29 548  E AndroidRuntime 18020      at com xyz dummy FadiaFragmentActivity onFriendAddedAsyncTask onPostExecute FadiaFragmentActivity java 461  01-06 14 54 29 548  E AndroidRuntime 18020      at com xyz dummy FadiaFragmentActivity onFriendAddedAsyncTask onPostExecute FadiaFragmentActivity java 1  01-06 14 54 29 548  E AndroidRuntime 18020      at android os AsyncTask finish AsyncTask java 417  01-06 14 54 29 548  E AndroidRuntime 18020      at android os AsyncTask access 300 AsyncTask java 127  01-06 14 54 29 548  E AndroidRuntime 18020      at android os AsyncTask InternalHandler handleMessage AsyncTask java 429  01-06 14 54 29 548  E AndroidRuntime 18020      at android os Handler dispatchMessage Handler java 99  01-06 14 54 29 548  E AndroidRuntime 18020      at android os Looper loop Looper java 123  01-06 14 54 29 548  E AndroidRuntime 18020      at android app ActivityThread main ActivityThread java 4627  01-06 14 54 29 548  E AndroidRuntime 18020      at java lang reflect Method invokeNative Native Method  01-06 14 54 29 548  E AndroidRuntime 18020      at java lang reflect Method invoke Method java 521  01-06 14 54 29 548  E AndroidRuntime 18020      at com android internal os ZygoteInit MethodAndArgsCaller run ZygoteInit java 858  01-06 14 54 29 548  E AndroidRuntime 18020      at com android internal os ZygoteInit main ZygoteInit java 616  01-06 14 54 29 548  E AndroidRuntime 18020      at dalvik system NativeStart main Native Method    I get the same IllegalStateExeption when I implement the AsynTask as follows  because the findFragmentById   method returns a null pointer   private class onFriendAddedAsyncTask extends AsyncTask lt String  Void  String gt         protected void onPreExecute             Log v  MyFragmentActivity    onFriendAddedAsyncTask onPreExecute            FragmentManager fm   getSupportFragmentManager            FragmentTransaction ft   fm beginTransaction            DummyFragment dummyFragment   DummyFragment newInstance            ft add R id dummy fragment layout  dummyFragment           ft commit               protected void onPostExecute String result            Log v  MyFragmentActivity    onFriendAddedAsyncTask onPostExecute            FragmentManager fm   getSupportFragmentManager            FragmentTransaction ft   fm beginTransaction            DummyFragment dummyFragment    DummyFragment  fm findFragmentById R id dummy fragment layout           ft remove dummyFragment           ft commitAllowingStateLoss            In the next step I use a handler for the adding and removing the DummyFragment  Additionally I ve added some more debug output   private class onFriendAddedAsyncTask extends AsyncTask lt String  Void  String gt          Override     protected void onPreExecute             Log v  MyFragmentActivity    onFriendAddedAsyncTask onPreExecute     getSupportFragmentManager             Log v  MyFragmentActivity    onFriendAddedAsyncTask onPreExecute     getSupportFragmentManager   findFragmentById R id dummy fragment layout            Log v  MyFragmentActivity    onFriendAddedAsyncTask onPreExecute     getSupportFragmentManager   findFragmentById R id friend list fragment layout             new Handler   post new Runnable                 public void run                     Log v  MyFragmentActivity    onFriendAddedAsyncTask onPreExecute     getSupportFragmentManager                     Log v  MyFragmentActivity    onFriendAddedAsyncTask onPreExecute     getSupportFragmentManager   findFragmentById R id dummy fragment layout                    Log v  MyFragmentActivity    onFriendAddedAsyncTask onPreExecute     getSupportFragmentManager   findFragmentById R id friend list fragment layout                    FragmentManager fm   getSupportFragmentManager                    FragmentTransaction ft   fm beginTransaction                    DummyFragment dummyFragment   DummyFragment newInstance                    ft add R id dummy fragment layout  dummyFragment                   ft commit                                    Override     protected void onPostExecute String result            Log v  MyFragmentActivity    onFriendAddedAsyncTask onPostExecute     getSupportFragmentManager             Log v  MyFragmentActivity    onFriendAddedAsyncTask onPostExecute     getSupportFragmentManager   findFragmentById R id dummy fragment layout            Log v  MyFragmentActivity    onFriendAddedAsyncTask onPostExecute     getSupportFragmentManager   findFragmentById R id friend list fragment layout             new Handler   post new Runnable                 public void run                     Log v  MyFragmentActivity    onFriendAddedAsyncTask onPostExecute     getSupportFragmentManager                     Log v  MyFragmentActivity    onFriendAddedAsyncTask onPostExecute     getSupportFragmentManager   findFragmentById R id dummy fragment layout                    Log v  MyFragmentActivity    onFriendAddedAsyncTask onPostExecute     getSupportFragmentManager   findFragmentById R id friend list fragment layout                    FragmentManager fm   getSupportFragmentManager                    FragmentTransaction ft   fm beginTransaction                    DummyFragment dummyFragment    DummyFragment  fm findFragmentById R id dummy fragment layout                   ft remove dummyFragment                   ft commitAllowingStateLoss                                I get following LogCut   01-07 19 00 17 273  V MyFragmentActivity 4124   onFriendAddedAsyncTask onPreExecute FragmentManager 45e384a8 in MyFragmentActivity 45e38358   01-07 19 00 17 273  V MyFragmentActivity 4124   onFriendAddedAsyncTask onPreExecute null 01-07 19 00 17 273  V MyFragmentActivity 4124   onFriendAddedAsyncTask onPreExecute FriendListFragment 45e38ab0  0 id 0x7f0a0002  01-07 19 00 17 283  V MyFragmentActivity 4124   onFriendAddedAsyncTask onPreExecute FragmentManager 45e384a8 in MyFragmentActivity 45e38358   01-07 19 00 17 288  V MyFragmentActivity 4124   onFriendAddedAsyncTask doInBackground 01-07 19 00 17 288  V MyFragmentActivity 4124   onFriendAddedAsyncTask onPreExecute null 01-07 19 00 17 288  V MyFragmentActivity 4124   onFriendAddedAsyncTask onPreExecute FriendListFragment 45e38ab0  0 id 0x7f0a0002  01-07 19 00 17 308  V DummyFragment 4124   onAttach DummyFragment 45dd7498  2 id 0x7f0a0004  01-07 19 00 17 308  V DummyFragment 4124   onCreate DummyFragment 45dd7498  2 id 0x7f0a0004  01-07 19 00 17 308  V DummyFragment 4124   onCreateView DummyFragment 45dd7498  2 id 0x7f0a0004  01-07 19 00 17 308  V DummyFragment 4124   onActivityCreated DummyFragment 45dd7498  2 id 0x7f0a0004  01-07 19 00 17 308  V DummyFragment 4124   onStart DummyFragment 45dd7498  2 id 0x7f0a0004  01-07 19 00 17 313  V DummyFragment 4124   onResume DummyFragment 45dd7498  2 id 0x7f0a0004  01-07 19 00 18 098  V MyFragmentActivity 4124   onSaveInstanceState DummyFragment 45dd7498  2 id 0x7f0a0004  01-07 19 00 18 098  V DummyFragment 4124   onSaveInstanceState DummyFragment 45dd7498  2 id 0x7f0a0004  01-07 19 00 18 098  V MyFragmentActivity 4124   onPause DummyFragment 45dd7498  2 id 0x7f0a0004  01-07 19 00 18 098  V DummyFragment 4124   onPause DummyFragment 45dd7498  2 id 0x7f0a0004  01-07 19 00 18 103  V MyFragmentActivity 4124   onStop DummyFragment 45dd7498  2 id 0x7f0a0004  01-07 19 00 18 103  V DummyFragment 4124   onStop DummyFragment 45dd7498  2 id 0x7f0a0004  01-07 19 00 18 103  V MyFragmentActivity 4124   onDestroy DummyFragment 45dd7498  2 id 0x7f0a0004  01-07 19 00 18 103  V DummyFragment 4124   onDestroyView DummyFragment 45dd7498  2 id 0x7f0a0004  01-07 19 00 18 108  V DummyFragment 4124   onDestroy DummyFragment 45dd7498  2 id 0x7f0a0004  01-07 19 00 18 113  V DummyFragment 4124   onDetach DummyFragment 45dd7498  2 id 0x7f0a0004  01-07 19 00 18 138  V MyFragmentActivity 4124   onCreate 01-07 19 00 18 138  V FriendListFragment 4124   FriendListFragment 01-07 19 00 18 138  V FriendListFragment 4124   onAttach FriendListFragment 45e4a7f8  0 id 0x7f0a0002  01-07 19 00 18 138  V FriendListFragment 4124   onCreate FriendListFragment 45e4a7f8  0 id 0x7f0a0002  01-07 19 00 18 148  V DummyFragment 4124   onAttach DummyFragment 45d7d1a0  2 id 0x7f0a0004  01-07 19 00 18 153  V DummyFragment 4124   onCreate DummyFragment 45d7d1a0  2 id 0x7f0a0004  01-07 19 00 18 523  V MyFragmentActivity 4124   onStart DummyFragment 45d7d1a0  2 id 0x7f0a0004  01-07 19 00 18 543  V FriendListFragment 4124   onActivityCreated FriendListFragment 45e4a7f8  0 id 0x7f0a0002  01-07 19 00 18 548  V DummyFragment 4124   onCreateView DummyFragment 45d7d1a0  2 id 0x7f0a0004  01-07 19 00 18 548  V DummyFragment 4124   onActivityCreated DummyFragment 45d7d1a0  2 id 0x7f0a0004  01-07 19 00 18 548  V FriendListFragment 4124   onLoadFinished FragmentManager 45d8e478 in MyFragmentActivity 45e4a6d8   01-07 19 00 18 548  V FriendListFragment 4124   onLoadFinished FriendListFragment 45e4a7f8  0 id 0x7f0a0002  01-07 19 00 18 553  V DummyFragment 4124   onStart DummyFragment 45d7d1a0  2 id 0x7f0a0004  01-07 19 00 18 553  V FriendListFragment 4124   onLoadFinished FragmentManager 45d8e478 in MyFragmentActivity 45e4a6d8   01-07 19 00 18 553  V FriendListFragment 4124   onLoadFinished FriendListFragment 45e4a7f8  0 id 0x7f0a0002  01-07 19 00 18 558  V MyFragmentActivity 4124   onResume DummyFragment 45d7d1a0  2 id 0x7f0a0004  01-07 19 00 18 558  V MyFragmentActivity 4124   onPostResume DummyFragment 45d7d1a0  2 id 0x7f0a0004  01-07 19 00 18 558  V MyFragmentActivity 4124   onResumeFragments DummyFragment 45d7d1a0  2 id 0x7f0a0004  01-07 19 00 18 558  V FriendListFragment 4124   onResume FriendListFragment 45e4a7f8  0 id 0x7f0a0002  01-07 19 00 18 563  V FriendListFragment 4124   onCreateLoader FriendListFragment 45e4a7f8  0 id 0x7f0a0002  01-07 19 00 18 563  V DummyFragment 4124   onResume DummyFragment 45d7d1a0  2 id 0x7f0a0004  01-07 19 00 18 723  V FriendListFragment 4124   onLoadFinished FragmentManager 45d8e478 in MyFragmentActivity 45e4a6d8   01-07 19 00 18 723  V FriendListFragment 4124   onLoadFinished FriendListFragment 45e4a7f8  0 id 0x7f0a0002  01-07 19 00 18 893  V MyFragmentActivity 4124   onFriendAddedAsyncTask onPostExecute FragmentManager 45e384a8 in null   01-07 19 00 18 893  V MyFragmentActivity 4124   onFriendAddedAsyncTask onPostExecute null 01-07 19 00 18 893  V MyFragmentActivity 4124   onFriendAddedAsyncTask onPostExecute null 01-07 19 00 18 923  V MyFragmentActivity 4124   onFriendAddedAsyncTask onPostExecute FragmentManager 45e384a8 in null   01-07 19 00 18 923  V MyFragmentActivity 4124   onFriendAddedAsyncTask onPostExecute null 01-07 19 00 18 923  V MyFragmentActivity 4124   onFriendAddedAsyncTask onPostExecute null 01-07 19 00 18 928  D AndroidRuntime 4124   Shutting down VM 01-07 19 00 18 928  W dalvikvm 4124   threadid 1  thread exiting with uncaught exception  group 0x4001d7d0  01-07 19 00 18 938  E AndroidRuntime 4124   FATAL EXCEPTION  main 01-07 19 00 18 938  E AndroidRuntime 4124   java lang IllegalStateException  Activity has been destroyed 01-07 19 00 18 938  E AndroidRuntime 4124       at android support v4 app FragmentManagerImpl enqueueAction FragmentManager java 1329  01-07 19 00 18 938  E AndroidRuntime 4124       at android support v4 app BackStackRecord commitInternal BackStackRecord java 548  01-07 19 00 18 938  E AndroidRuntime 4124       at android support v4 app BackStackRecord commitAllowingStateLoss BackStackRecord java 536  01-07 19 00 18 938  E AndroidRuntime 4124       at com xyz dummy MyFragmentActivity onFriendAddedAsyncTask 2 run MyFragmentActivity java 476  01-07 19 00 18 938  E AndroidRuntime 4124       at android os Handler handleCallback Handler java 587  01-07 19 00 18 938  E AndroidRuntime 4124       at android os Handler dispatchMessage Handler java 92  01-07 19 00 18 938  E AndroidRuntime 4124       at android os Looper loop Looper java 123  01-07 19 00 18 938  E AndroidRuntime 4124       at android app ActivityThread main ActivityThread java 4627  01-07 19 00 18 938  E AndroidRuntime 4124       at java lang reflect Method invokeNative Native Method  01-07 19 00 18 938  E AndroidRuntime 4124       at java lang reflect Method invoke Method java 521  01-07 19 00 18 938  E AndroidRuntime 4124       at com android internal os ZygoteInit MethodAndArgsCaller run ZygoteInit java 858  01-07 19 00 18 938  E AndroidRuntime 4124       at com android internal os ZygoteInit main ZygoteInit java 616  01-07 19 00 18 938  E AndroidRuntime 4124       at dalvik system NativeStart main Native Method    In onPreExecute   the FriendListFragment has the id 0x7f0a0002  Inside the handler the DummyFragment is created with id 0x7f0a0004  In onPostExecute   both IDs are null  In onPreExecute   the address of MyFragmentActivity is 45e38358  but in onPostExecute   it s null  But in both methods the FragmentManager address is 45e384a8  I guess onPostExecute uses an invalid FragmentManager  But why

User · Answer

Solution 1  override onSaveInstanceState   and remove the super call in it    Override public void onSaveInstanceState Bundle outState        Solution 2  override onSaveInstanceState   and remove your fragment before the super call   Override public void onSaveInstanceState Bundle outState            TODO  Add code to remove fragment here      super onSaveInstanceState outState

User · Answer

I had the same exception and I tried many snippet that I found here on this stackoverflow discussion, but no snippets worked for me.

But I was able to resolve all issues, I will share with you the solutions :

In a First part : I tried to show a DialogFragment on a Activity but from another java class. Then by checking the attribute of that instance, I found that was an old instance of the Activity, it was not the current running Activity. [More precisly I was using socket.io, and I forgot to do a socket.off("example",example) ... so it attached to an old instance of the activity. ]
In a Second part : I was trying to show a DialogFragment in a Activity when I come back to it with an intent, but when I checked my logs, I saw that when it tried to show the fragment the activity was still not in onStart method, so it crashed the app because it didn't find the Activity class to show the fragment on it.

Some tips : check with some attributes if you are not using an old instance of your activity with which one you are trying to show your fragment, or check your activity lifecycle before showing your fragment and be sure you are in onStart or onResume before showing it.

I hope those explanations will help you.

User · Answer

My app has a fragment to loading in 3 secs, but when the fist screen is preparing to show, I press home button and resume run it, it show the same error, so It edit my code and it ran very smooth:

new Handler().post(new Runnable() {
        public void run() {
            if (saveIns == null) {
                mFragment = new Fragment_S1_loading();
                getFragmentManager().beginTransaction()
                        .replace(R.id.container, mFragment).commit();
            }
            getActionBar().hide();
            // Loading screen in 3 secs:
            mCountDownTimerLoading = new CountDownTimer(3000, 1000) {

                @Override
                public void onTick(long millisUntilFinished) {

                }

                @Override
                public void onFinish() {
                    if (saveIns == null) {// TODO bug when start app and press home
                                            // button
                        getFragmentManager()
                                .beginTransaction()
                                .replace(R.id.container,
                                        new Fragment_S2_sesstion1()).commitAllowingStateLoss();
                    }
                    getActionBar().show();
                }
            }.start();
        }
    });

NOTE: add commitAllowingStateLoss() instead of commit()

User · Answer

Use commitAllowingStateLoss   instead of  commit     when you use commit   it will can throw an exception if state loss occurs but commitAllowingStateLoss   saves transaction without state loss so that will doesn t throw an exception if state loss occurs

User · Answer

Check if the activity isFinishing   before showing the fragment   Example   if  isFinishing      FragmentManager fm   getSupportFragmentManager                FragmentTransaction ft   fm beginTransaction                DummyFragment dummyFragment   DummyFragment newInstance                ft add R id dummy fragment layout  dummyFragment               ft commitAllowingStateLoss

User · Answer

The reason for the exception is the re-creation of the FragmentActivity during the runtime of the AsyncTask and the access to the previous, destroyed FragmentActivity in onPostExecute() afterwards.

The problem is to get a valid reference to the new FragmentActivity. There is no method for this neither getActivity() nor findById() or something similar. This forum is full of threads according this issue (e.g. search for "Activity context in onPostExecute"). Some of them are describing workarounds (until now I didn't find a good one).

Maybe it would be a better solution to use a Service for my purpose.

User · Answer

You should do the transaction in a Handler as follows    Override protected void onPostExecute String result        Log v  MyFragmentActivity    onFriendAddedAsyncTask onPostExecute        new Handler   post new Runnable                 public void run                     fm   getSupportFragmentManager                    ft   fm beginTransaction                    ft remove dummyFragment                   ft commit

User · Answer

Thanks Oleg Vaskevich  Using a WeakReference of the FragmentActivity solved the problem  My code looks as follows now   public class MyFragmentActivity extends FragmentActivity implements OnFriendAddedListener        private static WeakReference lt MyFragmentActivity gt  wrActivity   null        Override     public void onCreate Bundle savedInstanceState            super onCreate savedInstanceState           wrActivity   new WeakReference lt MyFragmentActivity gt  this                    private class onFriendAddedAsyncTask extends AsyncTask lt String  Void  String gt              Override         protected void onPreExecute                 FragmentManager fm   getSupportFragmentManager                FragmentTransaction ft   fm beginTransaction                DummyFragment dummyFragment   DummyFragment newInstance                ft add R id dummy fragment layout  dummyFragment               ft commit                        Override         protected void onPostExecute String result                final Activity activity   wrActivity get                if  activity    null  amp  amp   activity isFinishing                      FragmentManager fm   activity getSupportFragmentManager                    FragmentTransaction ft   fm beginTransaction                    DummyFragment dummyFragment    DummyFragment  fm findFragmentById R id dummy fragment layout                   ft remove dummyFragment                   ft commitAllowingStateLoss

User · Answer

That happened for me  because I was invoking commit   from subfragment which was leaking activity  It kept activity as a property and on a rotation activity variable was not updated by onAttach    So I was trying to commit transaction on zombie Activity by retained  setRetainInstance true    fragment

User · Answer

I believe the correct answer to this question is the following method.

public abstract int commitAllowingStateLoss ()

Like commit() but allows the commit to be executed after an activity's state is saved. This is dangerous because the commit can be lost if the activity needs to later be restored from its state, so this should only be used for cases where it is okay for the UI state to change unexpectedly on the user.

The above description relates to this method.

protected void onSaveInstanceState(android.os.Bundle outState)

This problem occurs precisely when the device goes to sleep.

http://developer.android.com/reference/android/app/FragmentTransaction.html

User · Answer

Short And working Solution    Follow Simple Steps    Step 1   Override onSaveInstanceState state in respective fragment  And remove super method from it    Override public void onSaveInstanceState Bundle outState        Step 2   Use CommitAllowingStateLoss    instead of commit    while fragment operations   fragmentTransaction commitAllowingStateLoss

User · Answer

There is one alternate solution  NOT the best solution  for this problem  but works  Using flag you can handle it  like below         Flag to avoid  java lang IllegalStateException  Can not perform this action after    onSaveInstanceState   Avoid Fragment transaction until onRestoreInstanceState or onResume    gets called      private boolean isOnSaveInstanceStateCalled   false     Override public void onRestoreInstanceState final Bundle bundle                  isOnSaveInstanceStateCalled   false                Override public void onSaveInstanceState final Bundle outState                  isOnSaveInstanceStateCalled   true                Override public void onResume         super onResume        isOnSaveInstanceStateCalled   false                And you can check this boolean value while doing fragment transaction   private void fragmentReplace Fragment fragment  String fragmentTag       if   isOnSaveInstanceStateCalled            getSupportFragmentManager                    beginTransaction                    replace R id layout container  fragment  fragmentTag                   commit

User · Answer

IllegalStateException is encountered if you commit any fragment transaction after the activity has lost its state- Activity is not in foreground. This is commonly encountered when you try to commit any fragment in AsyncTask or after a network request.

To avoid this crash you just need to delay any fragment transaction untill the state of activity is restored. Following is how it is done

Declare two private boolean variables

public class MainActivity extends AppCompatActivity {

    //Boolean variable to mark if the transaction is safe
    private boolean isTransactionSafe;

    //Boolean variable to mark if there is any transaction pending
    private boolean isTransactionPending;

Now in onPostResume() and onPause we set and unset our boolean variable isTransactionSafe. Idea is to mark trasnsaction safe only when the activity is in foreground so there is no chance of stateloss.

/*
onPostResume is called only when the activity's state is completely restored. In this we will
set our boolean variable to true. Indicating that transaction is safe now
 */
public void onPostResume(){
    super.onPostResume();
    isTransactionSafe=true;
}
/*
onPause is called just before the activity moves to background and also before onSaveInstanceState. In this
we will mark the transaction as unsafe
 */

public void onPause(){
    super.onPause();
    isTransactionSafe=false;

}

private void commitFragment(){
    if(isTransactionSafe) {
        MyFragment myFragment = new MyFragment();
        FragmentManager fragmentManager = getFragmentManager();
        FragmentTransaction fragmentTransaction = fragmentManager.beginTransaction();
        fragmentTransaction.add(R.id.frame, myFragment);
        fragmentTransaction.commit();
    }
}

What we have done so far will save from IllegalStateException but our transactions will be lost if they are done after the activity moves to background, kind of like commitAllowStateloss(). To help with that we have isTransactionPending boolean variable

public void onPostResume(){
   super.onPostResume();
   isTransactionSafe=true;
/* Here after the activity is restored we check if there is any transaction pending from
the last restoration
*/
   if (isTransactionPending) {
      commitFragment();
   }
}


private void commitFragment(){

 if(isTransactionSafe) {
     MyFragment myFragment = new MyFragment();
     FragmentManager fragmentManager = getFragmentManager();
     FragmentTransaction fragmentTransaction = fragmentManager.beginTransaction();
     fragmentTransaction.add(R.id.frame, myFragment);
     fragmentTransaction.commit();
     isTransactionPending=false;
 }else {
     /*
     If any transaction is not done because the activity is in background. We set the
     isTransactionPending variable to true so that we can pick this up when we come back to
foreground
     */
     isTransactionPending=true;
 }
}

This article explains quite in detail of why this exception is encountered and compares various methods to resolve it . Highly recommended

User · Answer

For what it s worth  I had this error on a app that was running services in the background  On one of them a timeout dialog had to be shown to the user  That dialog was the issue causing this error if the app was no longer running in the foreground   In our case showing the dialog wasn t useful when app was in background so we just kept track of that  boolean flagged onPause en onResume  and then only show the dialog when the app is actually visible to the user

User · Answer

This solved my problem  Kotlin Code  val fragmentTransaction   activity supportFragmentManager beginTransaction   fragmentTransaction add dialogFragment  tag  fragmentTransaction commitAllowingStateLoss    How is commitAllowingStateLoss   is different than commit     As per documentation  Like commit   but allows the commit to be executed after an activity s state is saved  https   developer android com reference android app FragmentTransaction commitAllowingStateLoss   P S  you can show Fragment Dialogs or can load fragments by this method  Applicable for both

User · Answer

This problem happens when a process tries to manipulate an Activity whose onStop() has been called. It's not necessarily tied to fragment transaction but also other methods like onBackPressed().

In addition to AsyncTask, another source of such problem is the misplacement of bus pattern's subscription. Usually Event Bus or RxBus's subscription is registered during Activity's onCreate and de-registered in onDestroy. If a new Activity starts and publishes an event intercepted by subscribers from the previous Activity then it may produce this error. If this happens then one solution is to move subscription registration and de-registration to onStart() and onStop().

User · Answer

Starting from support library version 24 0 0 you can call FragmentTransaction commitNow   method which commits this transaction synchronously instead of calling commit   followed by executePendingTransactions

User · Answer

I had a similar problem which I fixed by moving some fragment transaction code from onResume() into onStart().

To be more precise: My app is a launcher. After pressing the Android Home button, the user can choose a launcher until his/her decision is remembered. When going "back" at this point (e. g. by tapping in the greyish area) the app crashed.

Maybe this helps somebody.

[android] java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState

The answer is

Examples related to android

Examples related to exception

Examples related to android-asynctask

Examples related to android-fragments

Examples related to illegalstateexception

Tags