getting exception IllegalStateException Can not perform this action after onSaveInstanceState

Question

I have a Live Android application  and from market i have received following stack trace and i have no idea why its happening as its not happening in application code but its getting caused by some or the other event from the application  assumption    I am not using Fragments  still there is a reference of FragmentManager  If any body can throw some light on some hidden facts to avoid this type of issue   java lang IllegalStateException  Can not perform this action after onSaveInstanceState at android app FragmentManagerImpl checkStateLoss FragmentManager java 1109  at android app FragmentManagerImpl popBackStackImmediate FragmentManager java 399  at android app Activity onBackPressed Activity java 2066  at android app Activity onKeyDown Activity java 1962  at android view KeyEvent dispatch KeyEvent java 2482  at android app Activity dispatchKeyEvent Activity java 2274  at com android internal policy impl PhoneWindow DecorView dispatchKeyEvent PhoneWindow java 1668  at android view ViewGroup dispatchKeyEvent ViewGroup java 1112  at android view ViewGroup dispatchKeyEvent ViewGroup java 1112  at android view ViewGroup dispatchKeyEvent ViewGroup java 1112  at android view ViewGroup dispatchKeyEvent ViewGroup java 1112  at android view ViewGroup dispatchKeyEvent ViewGroup java 1112  at android view ViewGroup dispatchKeyEvent ViewGroup java 1112  at com android internal policy impl PhoneWindow DecorView superDispatchKeyEvent PhoneWindow java 1720  at com android internal policy impl PhoneWindow superDispatchKeyEvent PhoneWindow java 1258  at android app Activity dispatchKeyEvent Activity java 2269  at com android internal policy impl PhoneWindow DecorView dispatchKeyEvent PhoneWindow java 1668  at android view ViewRoot deliverKeyEventPostIme ViewRoot java 2851  at android view ViewRoot handleFinishedEvent ViewRoot java 2824  at android view ViewRoot handleMessage ViewRoot java 2011  at android os Handler dispatchMessage Handler java 99  at android os Looper loop Looper java 132  at android app ActivityThread main ActivityThread java 4025  at java lang reflect Method invokeNative Native Method  at java lang reflect Method invoke Method java 491  at com android internal os ZygoteInit MethodAndArgsCaller run ZygoteInit java 841  at com android internal os ZygoteInit main ZygoteInit java 599  at dalvik system NativeStart main Native Method

User · Answer

Simply call super onPostResume   before showing your fragment or move your code in onPostResume   method after calling super onPostResume    This solve the problem

User · Answer

I think Lifecycle state can help to prevent such crash starting from Android support lib v26 1 0 you can have the following check   if  getLifecycle   getCurrentState   isAtLeast Lifecycle State STARTED         Do fragment s transaction commit     or you can try   Fragment isStateSaved     more information here https   developer android com reference android support v4 app Fragment html isStateSaved

User · Answer

I got this issue But I think this problem is not related to commit and commitAllowStateLoss   The following stack trace and exception message is about commit     java lang IllegalStateException  Can not perform this action after onSaveInstanceState at android support v4 app FragmentManagerImpl checkStateLoss FragmentManager java 1341  at android support v4 app FragmentManagerImpl enqueueAction FragmentManager java 1352  at android support v4 app BackStackRecord commitInternal BackStackRecord java 595  at android support v4 app BackStackRecord commit BackStackRecord java 574    But this exception was caused by onBackPressed    java lang IllegalStateException  Can not perform this action after onSaveInstanceState at android support v4 app FragmentManagerImpl checkStateLoss Unknown Source  at android support v4 app FragmentManagerImpl popBackStackImmediate Unknown Source  at android support v4 app FragmentActivity onBackPressed Unknown Source    They were all caused by checkStateLoss    private void checkStateLoss         if  mStateSaved            throw new IllegalStateException                   Can not perform this action after onSaveInstanceState              if  mNoTransactionsBecause    null            throw new IllegalStateException                   Can not perform this action inside of     mNoTransactionsBecause           mStateSaved will be true after onSaveInstanceState   This problem rarely happens I have never encountered this problem I can not reoccurrence the problem   I found issue 25517  It might have occurred in the following circumstances   Back key is called after onSaveInstanceState  but before the new activity is started  use onStop   in code   I m not sure what the root of the problem is  So I used an ugly way    Override public void onBackPressed          try          super onBackPressed         catch  IllegalStateException e              can output some information here         finish

User · Answer

onSaveInstance will be called if a user rotates the screen so that it can load resources associated with the new orientation   It s possible that this user rotated the screen followed by pressing the back button  because it s also possible that this user fumbled their phone while using your app

User · Answer

I was always getting this when I tried to show fragment in onActivityForResult   method  so the problem was next    My Activity is paused and stopped  which means  that onSaveInstanceState   was called already  for both pre-Honeycomb and post-Honeycomb devices   In case of any result I made transaction to show hide fragment  which causes this IllegalStateException    What I made is next    Added value for determining if action I want was done  e g  taking photo from camere - isPhotoTaken  - it can be boolean or integer value depending how much different transactions you need  In overriden onResumeFragments   method I checked for my value and after made fragment transactions I needed  In this case commit   was not done after onSaveInstanceState  as state was returned in onResumeFragments   method

User · Answer

I noticed something very interesting  I have in my app the option to open the phone s gallery and the device asks what app to use  there I click on the gray area away from the dialog and saw this issue  I noticed how my activity goes from onPause  onSaveInstanceState back to onResume  it doesn t happen to visit onCreateView  I am doing transactions at onResume  So what I ended up doing is setting a flag being negated onPause  but being true onCreateView  if the flag is true onResume then do onCommit  otherwise commitAllowingStateLoss  I could go on and waste so much time but I wanted to check the lifecycle  I have a device which is sdkversion 23  and I don t get this issue  but I have another one which is 21  and there I see it

User · Answer

This is fixed in Android 4 2 and also in the support library s source      For details of the cause  and work-arounds  refer to the the Google bug report  http   code google com p android issues detail id 19917  If you re using the support library then you shouldn t have to worry about this bug  for long      However  if you re using the API directly  i e  Not using the support library s FragmentManager  and targeting an API below Android 4 2 then you will need to try one of the work-arounds       At the time of writing the Android SDK Manager is still distributing an old version that exhibits this bug   Edit I m going to add some clarification here because I ve obviously somehow confused whoever down-voted this answer   There are several different  but related  circumstances that can cause this exception to be thrown  My answer above is referring to the specific instance discussed in the question i e  a bug in Android which has subsequently been fixed  If you re getting this exception for another reason it s because you re adding removing fragments when you shouldn t be  after fragment states have been saved   If you re in such a situation then perhaps  Nested Fragments - IllegalStateException    Can not perform this action after onSaveInstanceState     can be of use to you

User · Answer

My use case  I have used listener in fragment to notify activity that some thing happened  I did new fragment commit on callback method  This works perfectly fine on first time  But on orientation change the activity is recreated with saved instance state  In that case fragment is not created again implies that the fragment have the listener which is old destroyed activity  Any way the call back method will get triggered on action  It goes to destroyed activity which cause the issue  The solution is to reset the listener in fragment with current live activity  This solve the problem

User · Answer

this worked for me    found this out on my own    hope it helps you   1  do NOT have a global  static  FragmentManager   FragmentTransaction   2  onCreate  ALWAYS initialize the FragmentManager again   sample below  -  public abstract class FragmentController extends AnotherActivity  protected FragmentManager fragmentManager  protected FragmentTransaction fragmentTransaction  protected Bundle mSavedInstanceState    Override protected void onCreate Bundle savedInstanceState        super onCreate savedInstanceState       mSavedInstanceState   savedInstanceState      setDefaultFragments       protected void setDefaultFragments         fragmentManager   getSupportFragmentManager          check if on orientation change   do not re-add fragments      if mSavedInstanceState    null              instantiate the fragment manager          fragmentTransaction   fragmentManager beginTransaction               the navigation fragments         NavigationFragment navFrag   new NavigationFragment            ToolbarFragment toolFrag   new ToolbarFragment             fragmentTransaction add R id NavLayout  navFrag   NavFrag            fragmentTransaction add R id ToolbarLayout  toolFrag   ToolFrag            fragmentTransaction commitAllowingStateLoss               add own fragment to the nav  abstract method          setOwnFragment

User · Answer

Such an exception will occur if you try to perform a fragment transition after your fragment activity s onSaveInstanceState   gets called    One reason this can happen  is if you leave an AsyncTask  or Thread  running when an activity gets stopped   Any transitions after onSaveInstanceState   is called could potentially get lost if the system reclaims the activity for resources and recreates it later

User · Answer

This is the most stupid bug I have encountered so far  I had a Fragment application working perfectly for API  lt  11  and Force Closing on API   11   I really couldn t figure out what they changed inside the Activity lifecycle in the call to saveInstance  but I here is how I solved this     Override protected void onSaveInstanceState Bundle outState          No call for super    Bug on API Level  gt  11      I just do not make the call to  super   and everything works great  I hope this will save you some time   EDIT  after some more research  this is a known bug in the support package    If you need to save the instance  and add something to your outState Bundle you can use the following     Override protected void onSaveInstanceState Bundle outState        outState putString  WORKAROUND FOR BUG 19917 KEY    WORKAROUND FOR BUG 19917 VALUE        super onSaveInstanceState outState       EDIT2  this may also occur if you are trying to perform a transaction after your Activity is gone in background  To avoid this you should use commitAllowingStateLoss    EDIT3  The above solutions were fixing issues in the early support v4 libraries from what I can remember  But if you still have issues with this you MUST also read  AlexLockwood  s blog   Fragment Transactions  amp  Activity State Loss Summary from the blog post  but I strongly recommend you to read it      NEVER commit   transactions after onPause   on pre-Honeycomb  and onStop   on post-Honeycomb Be careful when committing transactions inside Activity lifecycle methods  Use onCreate    onResumeFragments   and onPostResume   Avoid performing transactions inside asynchronous callback methods Use commitAllowingStateLoss   only as a last resort

User · Answer

you can use FragmentActivity onStart before popBackStackImmediate   like this   public void backStackFragment         this start        getFragmentManager   popBackStackImmediate       public void start        FragmentActivity a   getActivity        if a instanceof DepositPlanPadActivity           DepositPlanPadActivity a  onStart              if a instanceof SmallChangePlanPad                 SmallChangePlanPad a  onStart                      if a instanceof UserCenterActivity                 UserCenterActivity a  onStart                      http   jorryliu blogspot com 2014 09 illegalstateexception-can-not-perform html

User · Answer

Well  after trying all the above solutions without success  because basically i dont have transactions    On my case i was using AlertDialogs and ProgressDialog as fragments that  sometimes  on rotation  when asking for the FragmentManager  the error rises   I found a workaround mixing some many similar posts   Its a 3 step solution  all done on your FragmentActivity  in this case  its called GenericActivity    private static WeakReference lt GenericActivity gt  activity   null    To avoid bug for fragments  Step 1 of 3   Override protected void onCreate Bundle savedInstanceState       super onCreate savedInstanceState         To avoid bug for fragments  Step 2 of 3     activity   new WeakReference lt GenericActivity gt  this       Override public FragmentManager getSupportFragmentManager          To avoid bug for fragments  Step 3 of 3     if  this    activity get              return super getSupportFragmentManager              return activity get   getSupportFragmentManager

User · Answer

When i use startactivity in one fragment  i will get this exception   When i change to use startactivityforresult  the exception is gone      So the easy way to fix it is use the startActivityForResult api

User · Answer

You may be calling fragmentManager popBackStackImmediate    when activity is paused  Activity is not finished but is paused and not on foreground  You need to check whether activity is paused or not before popBackStackImmediate

User · Answer

This happens whenever you are trying to load a fragment but the activity has changed its state to onPause   This happens for example when you try to fetch data and load it to the activity but by the time the user has clicked some button and has moved to next activity   You can solve this in two ways  You can use transaction commitAllowingStateLoss   instead of transaction commit   to load fragment but you may end up losing commit operation that is done   or  Make sure that activity is in resume and not going to pause state when loading a fragment  Create a boolean and check if activity is not going to onPause   state    Override public void onResume         super onResume        mIsResumed   true      Override public void onPause         mIsResumed   false      super onPause        then while loading fragment check if activity is present and load only when activity is foreground   if mIsResumed      load the fragment

User · Answer

After researching a bit the solution to this problem is to do your fragment commits in the onresume   Source  https   wenchaojames wordpress com 2013 01 12 illegalstateexception-from-onactivityresult

User · Answer

Thanks  gunar  but I think there is a better way   According to doc        If you are committing a single transaction that does not modify the    fragment back stack  strongly consider using      link FragmentTransaction commitNow    instead  This can help avoid    unwanted side effects when other code in your app has pending committed    transactions that expect different timing         return Returns true if there were any pending transactions to be    executed      public abstract boolean executePendingTransactions       So use commitNow to replace   fragmentTransaction commit    FragmentManager executePendingTransactions

User · Answer

I think calling FragmentActivity onStateNotSaved   before those operations could be the best option by now

User · Answer

I have got the same issue in my App  I have been solved this issue just calling the super onBackPressed    on previous class and calling the commitAllowingStateLoss   on the current class with that fragment

User · Answer

I solved the issue with onconfigurationchanged  The trick is that according to android activity life cycle  when you explicitly called an intent camera intent  or any other one   the activity is paused and onsavedInstance is called in that case  When rotating the device to a different position other than the one during which the activity was active  doing fragment operations such as fragment commit causes Illegal state exception  There are lots of complains about it  It s something about android activity lifecycle management and proper method calls  To solve it I did this  1-Override the onsavedInstance method of your activity  and determine the current screen orientation portrait or landscape  then set your screen orientation to it before your activity is paused  that way the activity you lock the screen rotation for your activity in case it has been rotated by another one  2-then   override onresume method of activity  and set your orientation mode now to sensor so that after onsaved method is called it will call one more time onconfiguration to deal with the rotation properly   You can copy paste this code into your activity to deal with it    Override protected void onSaveInstanceState Bundle outState               super onSaveInstanceState outState        Toast makeText this   Activity OnResume    Lock Screen Orientation    Toast LENGTH LONG  show        int orientation  this getDisplayOrientation          Lock the screen orientation to the current display orientation   Landscape or Potrait     this setRequestedOrientation orientation        A method found in stackOverflow  don t remember the author  to determine the right screen orientation independently of the phone or tablet device  public int getDisplayOrientation         Display getOrient   getWindowManager   getDefaultDisplay         int orientation   getOrient getOrientation            Sometimes you may get undefined orientation Value is 0        simple logic solves the problem compare the screen        X Y Co-ordinates and determine the Orientation in such cases     if  orientation    Configuration ORIENTATION UNDEFINED            Configuration config   getResources   getConfiguration            orientation   config orientation           if  orientation    Configuration ORIENTATION UNDEFINED               if height and widht of screen are equal then            it is square orientation             if  getOrient getWidth      getOrient getHeight                      orientation   Configuration ORIENTATION SQUARE                else     if widht is less than height than it is portrait                 if  getOrient getWidth    lt  getOrient getHeight                          orientation   Configuration ORIENTATION PORTRAIT                    else      if it is not any of the above it will defineitly be landscape                     orientation   Configuration ORIENTATION LANDSCAPE                                                      return orientation     return value 1 is portrait and 2 is Landscape Mode     Override public void onResume         super onResume        Toast makeText this   Activity OnResume    Unlock Screen Orientation    Toast LENGTH LONG  show        setRequestedOrientation ActivityInfo SCREEN ORIENTATION SENSOR

User · Answer

I was getting this exception when I was pressing back button to cancel intent chooser on my map fragment activity  I resolved this by replacing the code of onResume   where I was initializing the fragment and committing transaction  to onStart   and the app is working fine now  Hope it helps

User · Answer

Short And working Solution    Follow Simple Steps    Step 1   Override onSaveInstanceState state in respective fragment  And remove super method from it    Override public void onSaveInstanceState Bundle outState         Step 2   Use CommitAllowingStateLoss    instead of commit    while fragment operations   fragmentTransaction commitAllowingStateLoss

User · Answer

Read http   chris-alexander co uk on-engineering dev android-fragments-within-fragments   article   fragment isResumed   checking helps me in onDestroyView w o using onSaveInstanceState method

User · Answer

What I found is that if another app is dialog type and allows touches to be sent to background app then almost any background app will crash with this error  I think we need to check every time a transaction is performed if the instance was saved or restored

User · Answer

This can also happen when calling dismiss   on a dialog fragment after the screen has been locked blanked and the Activity   dialog s instance state has been saved   To get around this call   dismissAllowingStateLoss     Literally every single time I m dismissing a dialog i don t care about it s state anymore anyway  so this is ok to do - you re not actually losing any state

User · Answer

Looking in Android source code on what causes this issue gives that flag mStateSaved in FragmentManagerImpl class  instance available in Activity  has value true  It is set to true when the back stack is saved  saveAllState  on call from Activity onSaveInstanceState  Afterwards the calls from ActivityThread don t reset this flag using available reset methods from FragmentManagerImpl noteStateNotSaved   and dispatch    The way I see it there are some available fixes  depending on what your app is doing and using  Good ways Before anything else  I would advertise Alex Lockwood article  Then  from what I ve done so far   For fragments and activities that don t need to keep any state information  call commitAllowStateLoss  Taken from documentation   Allows the commit to be executed after an activity s state is saved  This is dangerous because the commit can be lost if the activity needs to later be restored from its state  so this should only be used for cases where it is okay for the UI state to change unexpectedly on the user   I guess this is alright to use if the fragment is showing read-only information  Or even if they do show editable info  use the callbacks methods to retain the edited info    Just after the transaction is commit  you just called commit     make a call to FragmentManager executePendingTransactions      Not recommended ways   As Ovidiu Latcu mentioned above  don t call super onSaveInstanceState    But this means you will lose the whole state of your activity along with fragments state   Override onBackPressed and in there call only finish    This should be OK if you application doesn t use Fragments API  as in super onBackPressed there is a call to FragmentManager popBackStackImmediate     If you are using both Fragments API and the state of your activity is important vital  then you could try to call using reflection API FragmentManagerImpl noteStateNotSaved    But this is a hack  or one could say it s a workaround  I don t like it  but in my case it s quite acceptable since I have a code from a legacy app that uses deprecated code  TabActivity and implicitly LocalActivityManager     Below is the code that uses reflection   Override protected void onSaveInstanceState Bundle outState        super onSaveInstanceState outState       invokeFragmentManagerNoteStateNotSaved        SuppressWarnings    quot rawtypes quot    quot unchecked quot     private void invokeFragmentManagerNoteStateNotSaved                    For post-Honeycomb devices             if  Build VERSION SDK INT  lt  11            return            try           Class cls   getClass            do               cls   cls getSuperclass              while    quot Activity quot  equals cls getSimpleName              Field fragmentMgrField   cls getDeclaredField  quot mFragments quot            fragmentMgrField setAccessible true            Object fragmentMgr   fragmentMgrField get this           cls   fragmentMgr getClass             Method noteStateNotSavedMethod   cls getDeclaredMethod  quot noteStateNotSaved quot   new Class                noteStateNotSavedMethod invoke fragmentMgr  new Object                Log d  quot DLOutState quot    quot Successful call for noteStateNotSaved    quot          catch  Exception ex            Log e  quot DLOutState quot    quot Exception on worka FM noteStateNotSaved quot   ex            Cheers

User · Answer

Same issue from me and after a day long analysis of all articles  blog and stackoverflow i ve found a simple solution  Don t use savedInstanceState at all  this is the condition with one line of code  On the fragment code     Override public void onCreate Bundle savedInstanceState        super onCreate null

User · Answer

I had the same problem  getting IllegalStateException  but replacing all my calls to commit   with commitAllowingStateLoss   did not help   The culprit was a call to DialogFragment show     I surround it with  try       dialog show transaction   blah blah      catch IllegalStateException e        return      and that did it  OK  I don t get to show the dialog  but in this case that was fine   It was the only place in my app where I first called FragmentManager beginTransaction   but never called commit   so I did not find it when I looked for  commit      The funny thing is  the user never leaves the app  Instead the killer was an AdMob interstitial ad showing up

User · Answer

My solution for that problem was  In fragment add methods    Override public View onCreateView LayoutInflater inflater  ViewGroup container  Bundle savedInstanceState                guideMapFragment    SupportMapFragment a getSupportFragmentManager   findFragmentById R id guideMap       guideMap   guideMapFragment getMap                Override public void onDestroyView         SherlockFragmentActivity a   getSherlockActivity        if  a    null  amp  amp  guideMapFragment    null            try               Log i LOGTAG   Removing map fragment                a getSupportFragmentManager   beginTransaction   remove guideMapFragment  commit                guideMapFragment   null            catch IllegalStateException e                Log i LOGTAG   IllegalStateException on exit                        super onDestroyView        May be bad  but couldn t find anything better

User · Answer

In my case  with the same error exception  i put the  onBackPressed    in a runnable  you can use any of your view    myView post new Runnable                          Override                     public void run                             onBackPressed                                               I do not understand why  but it works

[android] getting exception "IllegalStateException: Can not perform this action after onSaveInstanceState"

Examples related to android

Examples related to illegalstateexception