How to use S ISREG and S ISDIR POSIX Macros

Question

This is a C program I wrote to recursively navigate and output directories and regular files   It compiles and runs fine on my Linux machine  But on Solaris  the dit- gt d type    8 check and the other similar ones don t work because there is no d type field   An answer I ve read to this problem is to use the S ISREG   and S ISDIR   macros  but they don t work at all the way I have them in my code currently   I commented out the lines that work on my Linux machine    include  lt sys types h gt   include  lt sys stat h gt   include  lt stdlib h gt   include  lt dirent h gt   include  lt stdio h gt   include  lt unistd h gt   include  lt errno h gt   include  lt string h gt   void helper DIR    struct dirent    struct stat  char    int  char      void dircheck DIR    struct dirent    struct stat  char    int  char       int main int argc  char  argv        DIR  dip    struct dirent  dit    struct stat statbuf    char currentPath FILENAME MAX     int depth   0    Used to correctly space output        Open Current Directory     if  dip   opendir          NULL      return errno       Store Current Working Directory in currentPath     if  getcwd currentPath  FILENAME MAX      NULL      return errno       Read all items in directory     while  dit   readdir dip      NULL         Skips   and          if strcmp dit- gt d name          0    strcmp dit- gt d name           0        continue       if stat currentPath   amp statbuf     -1         perror  stat          return errno               Checks if current item is of the type file  type 8  and no command line arguments       if dit- gt d type    8  amp  amp  argv 1     NULL        if S ISREG statbuf st mode   amp  amp  argv 1     NULL        printf   s   d bytes  n   dit- gt d name   int statbuf st size            If a command line argument is given  checks for filename match     if dit- gt d type    8  amp  amp  argv 1     NULL        if S ISREG statbuf st mode   amp  amp  argv 1     NULL        if strcmp dit- gt d name  argv 1      0          printf   s   d bytes  n   dit- gt d name   int statbuf st size            Checks if current item is of the type directory  type 4        if dit- gt d type    4        if S ISDIR statbuf st mode         dircheck dip  dit  statbuf  currentPath  depth  argv          closedir dip     return 0       Recursively called helper function   void helper DIR  dip  struct dirent  dit  struct stat statbuf       char currentPath FILENAME MAX   int depth  char  argv       int i   0     if  dip   opendir currentPath      NULL      printf  Error  Failed to open Directory    gt   s n   currentPath      while  dit   readdir dip      NULL        if strcmp dit- gt d name          0    strcmp dit- gt d name           0        continue       stat currentPath   amp statbuf          if dit- gt d type    8  amp  amp  argv 1     NULL         if S ISREG statbuf st mode   amp  amp  argv 1     NULL         for i   0  i  lt  depth  i            printf                printf   s   d bytes  n   dit- gt d name   int statbuf st size                if dit- gt d type    8  amp  amp  argv 1     NULL         if S ISREG statbuf st mode   amp  amp  argv 1     NULL         if strcmp dit- gt d name  argv 1      0       for i   0  i  lt  depth  i          printf              printf   s   d bytes  n   dit- gt d name   int statbuf st size                        if dit- gt d type    4        if S ISDIR statbuf st mode         dircheck dip  dit  statbuf  currentPath  depth  argv           void dircheck DIR  dip  struct dirent  dit  struct stat statbuf         char currentPath FILENAME MAX   int depth  char  argv       int i   0     strcat currentPath          strcat currentPath  dit- gt d name        If two directories exist at the same level the path     is built wrong and needs to be corrected     if  chdir currentPath      -1       chdir            getcwd currentPath  FILENAME MAX       strcat currentPath            strcat currentPath  dit- gt d name        for i   0  i  lt  depth  i          printf               printf   s  subdirectory  n   dit- gt d name       depth        helper dip  dit  statbuf  currentPath  depth  argv          else      for i  0  i  lt  depth  i          printf              printf   s  subdirectory  n   dit- gt d name       chdir currentPath       depth        helper dip  dit  statbuf  currentPath  depth  argv

User · Accepted Answer

You re using S ISREG   and S ISDIR   correctly  you re just using them on the wrong thing    In your while  dit   readdir dip      NULL  loop in main  you re calling stat on currentPath over and over again without changing currentPath   if stat currentPath   amp statbuf     -1        perror  stat        return errno      Shouldn t you be appending a slash and dit- gt d name to currentPath to get the full path to the file that you want to stat  Methinks that similar changes to your other stat calls are also needed

User · Answer

Posted on behalf of fossuser  Thanks to  mu is too short  I was able to fix the bug   Here is my working code has been edited in for those looking for a nice example  since I couldn t find any others online     include  lt sys types h gt   include  lt sys stat h gt   include  lt stdlib h gt   include  lt dirent h gt   include  lt stdio h gt   include  lt unistd h gt   include  lt errno h gt   include  lt string h gt   void helper DIR    struct dirent    struct stat  char    int  char      void dircheck DIR    struct dirent    struct stat  char    int  char       int main int argc  char  argv        DIR  dip    struct dirent  dit    struct stat statbuf    char currentPath FILENAME MAX     int depth   0    Used to correctly space output        Open Current Directory     if  dip   opendir          NULL      return errno       Store Current Working Directory in currentPath     if  getcwd currentPath  FILENAME MAX      NULL      return errno       Read all items in directory     while  dit   readdir dip      NULL          Skips   and          if strcmp dit- gt d name          0    strcmp dit- gt d name           0        continue         Correctly forms the path for stat and then resets it for rest of algorithm       getcwd currentPath  FILENAME MAX       strcat currentPath            strcat currentPath  dit- gt d name       if stat currentPath   amp statbuf     -1         perror  stat          return errno            getcwd currentPath  FILENAME MAX           Checks if current item is of the type file  type 8  and no command line arguments       if S ISREG statbuf st mode   amp  amp  argv 1     NULL        printf   s   d bytes  n   dit- gt d name   int statbuf st size          If a command line argument is given  checks for filename match       if S ISREG statbuf st mode   amp  amp  argv 1     NULL        if strcmp dit- gt d name  argv 1      0           printf   s   d bytes  n   dit- gt d name   int statbuf st size          Checks if current item is of the type directory  type 4        if S ISDIR statbuf st mode         dircheck dip  dit  statbuf  currentPath  depth  argv          closedir dip     return 0       Recursively called helper function   void helper DIR  dip  struct dirent  dit  struct stat statbuf           char currentPath FILENAME MAX   int depth  char  argv       int i   0     if  dip   opendir currentPath      NULL      printf  Error  Failed to open Directory    gt   s n   currentPath      while  dit   readdir dip      NULL        if strcmp dit- gt d name          0    strcmp dit- gt d name           0        continue       strcat currentPath            strcat currentPath  dit- gt d name       stat currentPath   amp statbuf       getcwd currentPath  FILENAME MAX        if S ISREG statbuf st mode   amp  amp  argv 1     NULL         for i   0  i  lt  depth  i        printf                printf   s   d bytes  n   dit- gt d name   int statbuf st size              if S ISREG statbuf st mode   amp  amp  argv 1     NULL         if strcmp dit- gt d name  argv 1      0       for i   0  i  lt  depth  i          printf              printf   s   d bytes  n   dit- gt d name   int statbuf st size                      if S ISDIR statbuf st mode         dircheck dip  dit  statbuf  currentPath  depth  argv           Changing back here is necessary because of how stat is done       chdir            closedir dip      void dircheck DIR  dip  struct dirent  dit  struct stat statbuf             char currentPath FILENAME MAX   int depth  char  argv       int i   0     strcat currentPath          strcat currentPath  dit- gt d name        If two directories exist at the same level the path     is built wrong and needs to be corrected     if  chdir currentPath      -1       chdir            getcwd currentPath  FILENAME MAX       strcat currentPath            strcat currentPath  dit- gt d name        for i   0  i  lt  depth  i          printf               printf   s  subdirectory  n   dit- gt d name       depth        helper dip  dit  statbuf  currentPath  depth  argv          else      for i  0  i  lt  depth  i          printf              printf   s  subdirectory  n   dit- gt d name       chdir currentPath       depth        helper dip  dit  statbuf  currentPath  depth  argv

[c] How to use S_ISREG() and S_ISDIR() POSIX Macros?

Examples related to c

Examples related to solaris

Examples related to stat

Examples related to readdir