PersistentObjectException detached entity passed to persist thrown by JPA and Hibernate

Question

I have a JPA-persisted object model that contains a many-to-one relationship  an Account has many Transactions  A Transaction has one Account   Here s a snippet of the code    Entity public class Transaction        Id      GeneratedValue strategy   GenerationType AUTO      private Long id        ManyToOne cascade    CascadeType ALL  fetch  FetchType EAGER      private Account fromAccount         Entity public class Account        Id      GeneratedValue strategy   GenerationType AUTO      private Long id       OneToMany cascade    CascadeType ALL  fetch  FetchType EAGER  mappedBy    fromAccount       private Set lt Transaction gt  transactions    I am able to create an Account object  add transactions to it  and persist the Account object correctly  But  when I create a transaction  using an existing already persisted Account   and persisting the the Transaction  I get an exception      Caused by  org hibernate PersistentObjectException  detached entity passed to persist  com paulsanwald Account           at org hibernate event internal DefaultPersistEventListener onPersist DefaultPersistEventListener java 141     So  I am able to persist an Account that contains transactions  but not a Transaction that has an Account  I thought this was because the Account might not be attached  but this code still gives me the same exception   if  account getId    null        account   entityManager merge account     Transaction transaction   new Transaction account  other stuff        the below fails with a  detached entity  message  why  entityManager persist transaction     How can I correctly save a Transaction  associated with an already persisted Account object

User · Answer

Probably in this case you obtained your account object using the merge logic  and persist is used to persist new objects and it will complain if the hierarchy is having an already persisted object  You should use saveOrUpdate in such cases  instead of persist

User · Answer

You need to set Transaction for every Account   foreach Account account   accounts       account setTransaction transactionObj       Or it colud be enough  if appropriate  to set ids to null on many side      list of existing accounts List lt Account gt  accounts   new ArrayList lt  gt  transactionObj getAccounts      foreach Account account   accounts       account setId null      transactionObj setAccounts accounts       just persist transactionObj using EntityManager merge   method

User · Answer

In your entity definition  you re not specifying the  JoinColumn for the Account joined to a Transaction  You ll want something like this    Entity public class Transaction        ManyToOne cascade    CascadeType ALL  fetch  FetchType EAGER       JoinColumn name    accountId   referencedColumnName    id       private Account fromAccount      EDIT  Well  I guess that would be useful if you were using the  Table annotation on your class  Heh

User · Answer

cascadeType MERGE fetch  FetchType LAZY

User · Answer

My Spring Data JPA-based answer  I simply added a  Transactional annotation to my outer method    Why it works  The child entity was immediately becoming detached because there was no active Hibernate Session context  Providing a Spring  Data JPA  transaction ensures a Hibernate Session is present   Reference   https   vladmihalcea com a-beginners-guide-to-jpa-hibernate-entity-state-transitions

User · Answer

Removing child association cascading So  you need to remove the  CascadeType ALL from the  ManyToOne association  Child entities should not cascade to parent associations  Only parent entities should cascade to child entities   ManyToOne fetch  FetchType LAZY   Notice that I set the fetch attribute to FetchType LAZY because eager fetching is very bad for performance  Setting both sides of the association Whenever you have a bidirectional association  you need to synchronize both sides using addChild and removeChild methods in the parent entity  public void addTransaction Transaction transaction        transcations add transaction       transaction setAccount this      public void removeTransaction Transaction transaction        transcations remove transaction       transaction setAccount null

User · Answer

Remove cascading from the child entity Transaction  it should be just    Entity class Transaction        ManyToOne    no cascading here      private Account account       FetchType EAGER can be removed as well as it s the default for  ManyToOne   That s all   Why  By saying  cascade ALL  on the child entity Transaction you require that every DB operation gets propagated to the parent entity Account  If you then do persist transaction   persist account  will be invoked as well    But only transient  new  entities may be passed to persist  Transaction in this case   The detached  or other non-transient state  ones may not  Account in this case  as it s already in DB     Therefore you get the exception  detached entity passed to persist   The Account entity is meant  Not the Transaction you call persist on     You generally don t want to propagate from child to parent  Unfortunately there are many code examples in books  even in good ones  and through the net  which do exactly that  I don t know  why    Perhaps sometimes simply copied over and over without much thinking      Guess what happens if you call remove transaction  still having  cascade ALL  in that  ManyToOne  The account  btw  with all other transactions   will be deleted from the DB as well  But that wasn t your intention  was it

User · Answer

Don t pass id pk   to persist method or try save   method instead of persist

User · Answer

Using merge is risky and tricky  so it s a dirty workaround in your case  You need to remember at least that when you pass an entity object to merge  it stops being attached to the transaction and instead a new  now-attached entity is returned  This means that if anyone has the old entity object still in their possession  changes to it are silently ignored and thrown away on commit   You are not showing the complete code here  so I cannot double-check your transaction pattern  One way to get to a situation like this is if you don t have a transaction active when executing the merge and persist  In that case persistence provider is expected to open a new transaction for every JPA operation you perform and immediately commit and close it before the call returns  If this is the case  the merge would be run in a first transaction and then after the merge method returns  the transaction is completed and closed and the returned entity is now detached  The persist below it would then open a second transaction  and trying to refer to an entity that is detached  giving an exception  Always wrap your code inside a transaction unless you know very well what you are doing   Using container-managed transaction it would look something like this  Do note  this assumes the method is inside a session bean and called via Local or Remote interface    TransactionAttribute TransactionAttributeType REQUIRED  public void storeAccount Account account                 if  account getId    null            account   entityManager merge account              Transaction transaction   new Transaction account  other stuff         entityManager persist account

User · Answer

This is a typical bidirectional consistency problem  It is well discussed in this link as well as this link   As per the articles in the previous 2 links you need to fix your setters in both sides of the bidirectional relationship  An example setter for the One side is in this link   An example setter for the Many side is in this link   After you correct your setters you want to declare the Entity access type to be  Property   Best practice to declare  Property  access type is to move ALL the annotations from the member properties to the corresponding getters  A big word of caution is not to mix  Field  and  Property  access types within the entity class otherwise the behavior is undefined by the JSR-317 specifications

User · Answer

If nothing helps and you are still getting this exception  review your equals   methods - and don t include child collection in it  Especially if you have deep structure of embedded collections  e g  A contains Bs  B contains Cs  etc     In example of Account - gt  Transactions     public class Account        private Long id      private String accountName      private Set lt Transaction gt  transactions        Override     public boolean equals Object obj          if  this    obj          return true        if  obj    null          return false        if    obj instanceof Account           return false        Account other    Account  obj        return Objects equals this id  other id             amp  amp  Objects equals this accountName  other accountName             amp  amp  Objects equals this transactions  other transactions       lt --- REMOVE THIS              In above example remove transactions from equals   checks  This is because hibernate will imply that you are not trying to update old object  but you pass a new object to persist  whenever you change element on the child collection  Of course this solutions will not fit all applications and you should carefully design what you want to include in the equals and hashCode methods

User · Answer

Maybe It is OpenJPA s bug  When rollback it reset the  Version field  but the pcVersionInit keep true  I have a AbstraceEntity which declared the  Version field  I can workaround it by reset the pcVersionInit field  But It is not a good idea  I think it not work when have cascade persist entity       private static Field PC VERSION INIT   null      static           try               PC VERSION INIT   AbstractEntity class getDeclaredField  pcVersionInit                PC VERSION INIT setAccessible true             catch  NoSuchFieldException   SecurityException e                         public T call final EntityManager em                    if  PC VERSION INIT    null  amp  amp  isDetached entity                         try                           PC VERSION INIT set entity  false                         catch  IllegalArgumentException   IllegalAccessException e                                                            em persist entity                   return entity                                                 param entity                 param detached                 return                             private boolean isDetached final Object entity                    if  entity instanceof PersistenceCapable                        PersistenceCapable pc    PersistenceCapable  entity                      if  pc pcIsDetached      Boolean TRUE                            return true                                                          return false

User · Answer

OneToMany mappedBy    xxxx   cascade  CascadeType MERGE  CascadeType PERSIST  CascadeType REMOVE   worked for me

User · Answer

The solution is simple  just use the CascadeType MERGE instead of CascadeType PERSIST or CascadeType ALL    I have had the same problem and CascadeType MERGE has worked for me   I hope you are sorted

User · Answer

In  my case I was committing transaction when persist method was used   On changing persist to save method   it got resolved

User · Answer

Resolved by saving dependent object before the next   This was happened to me because I was not setting Id  which was not auto generated   and trying to save with relation  ManytoOne

User · Answer

Even if your annotations are declared correctly to properly manage the one-to-many relationship you may still encounter this precise exception   When adding a new child object  Transaction  to an attached data model you ll need to manage the primary key value - unless you re not supposed to   If you supply a primary key value for a child entity declared as follows before calling persist T   you ll encounter this exception    Entity public class Transaction        Id      GeneratedValue strategy   GenerationType AUTO      private Long id         In this case  the annotations are declaring that the database will manage the generation of the entity s primary key values upon insertion   Providing one yourself  such as through the Id s setter  causes this exception   Alternatively  but effectively the same  this annotation declaration results in the same exception    Entity public class Transaction        Id      org hibernate annotations GenericGenerator name  system-uuid   strategy  uuid        GeneratedValue generator  system-uuid       private Long id         So  don t set the id value in your application code when it s already being managed

User · Answer

If above solutions not work just one time comment the getter and setter methods of entity class and do not set the value of id  Primary key  Then this will work

[java] PersistentObjectException: detached entity passed to persist thrown by JPA and Hibernate

Examples related to java

Examples related to hibernate

Examples related to jpa

Examples related to entity

Examples related to persist