Simple JavaScript problem onClick confirm not preventing default action

Question

I m making a simple remove link with an onClick event that brings up a confirm dialog  I want to confirm that the user wants to delete an entry  However  it seems that when Cancel is clicked in the dialog  the default action  i e  the href link  is still taking place  so the entry still gets deleted  Not sure what I m doing wrong here    Any input would be much appreciated   EDIT  Actually  the way the code is now  the page doesn t even make the function call    so  no dialog comes up at all  I did have the onClick code as   onClick  confirm  Delete entry       which did bring up a dialog  but was still going to the link on Cancel    lt    taglib prefix  c  uri  http   java sun com jstl core rt   gt   lt    taglib prefix  fmt  uri  http   java sun com jstl fmt rt   gt   lt    taglib uri  http   java sun com jsp jstl functions  prefix  fn    gt    lt script type  text javascript  gt   function delete         return confirm  Delete entry        lt  script gt          lt tr gt    lt c if test    userIDRO   gt       lt td gt           lt a href  showSkill htm row  lt c out value    skill employeeSkillId    gt     gt           lt img src  images edit GIF  ALT  Edit this skill   border  1   gt  lt  a gt       lt  td gt       lt td gt           lt a href  showSkill htm row  lt c out value    skill employeeSkillId  amp remove 1   gt   onClick  return delete     gt           lt img src  images remove GIF  ALT  Remove this skill   border  1   gt  lt  a gt       lt  td gt    lt  c if gt   lt  tr gt

User · Accepted Answer

There s a typo in your code  the tag a is closed too early   You can either use    lt a href  whatever  onclick  return confirm  are you sure     gt  lt img     gt  lt  a gt    note the return  confirm   the value returned by scripts in intrinsic evens decides whether the default browser action is run or not  in case you need to run a big piece of code you can of course call another function    lt script type  text javascript  gt  function confirm delete       return confirm  are you sure        lt  script gt       lt a href  whatever  onclick  return confirm delete    gt  lt img     gt  lt  a gt     note that delete is a keyword   For completeness  modern browsers also support DOM events  allowing you to register more than one handler for the same event on each object  access the details of the event  stop the propagation and much more  see DOM Events

User · Answer

Well  I used to have the same problem and the problem got solved by adding the word  return  before confirm   onclick  return confirm  Delete entry       I wish this could be heplful for you    Good Luck

User · Answer

First of all  delete is a reserved word in javascript  I m surprised this even executes for you  When I test it in Firefox  I get a syntax error   Secondly  your HTML looks weird - is there a reason you re closing the opening anchor tags with   gt  instead of just  gt

User · Answer

Using a simple link for an action such as removing a record looks dangerous to me   what if a crawler is trying to index your pages   It will ignore any javascript and follow every link  probably not a good thing   You d better use a form with method  POST    And then you will have an event  OnSubmit  to do exactly what you want

User · Answer

I use this  works like a charm  No need to have any functions  just inline with your link s   onclick  javascript return confirm  Are you sure you want to delete this comment

User · Answer

I use this  works like a charm  No need to have any functions  just inline with your link s   onclick  javascript return confirm  Are you sure you want to delete this comment

User · Answer

First of all  delete is a reserved word in javascript  I m surprised this even executes for you  When I test it in Firefox  I get a syntax error   Secondly  your HTML looks weird - is there a reason you re closing the opening anchor tags with   gt  instead of just  gt

User · Answer

First of all  delete is a reserved word in javascript  I m surprised this even executes for you  When I test it in Firefox  I get a syntax error   Secondly  your HTML looks weird - is there a reason you re closing the opening anchor tags with   gt  instead of just  gt

User · Answer

try this   OnClientClick  return  confirm  Are you sure you want to delete this comment

User · Answer

Well  I used to have the same problem and the problem got solved by adding the word  return  before confirm   onclick  return confirm  Delete entry       I wish this could be heplful for you    Good Luck

User · Answer

If you want to use small inline commands in the onclick tag you could go with something like this    lt button id    class  delete  onclick  javascript if confirm  Are you sure you want to delete this entry     jQuery this  parent   remove    return false    type  button  gt      Delete  lt  button gt

User · Answer

I ve had issue with IE7 and returning false before   Check my answer here to another problem  Javascript not running on IE

User · Answer

I use this  works like a charm  No need to have any functions  just inline with your link s   onclick  javascript return confirm  Are you sure you want to delete this comment

User · Answer

I had issue alike  click on button  but after cancel clicked it still removes my object   so made this in such way  hope it helps someone in the future        deleteObject   click function          var url   this href      var confirmText    Are you sure you want to delete this object        if confirm confirmText               ajax               type  POST               url url              success function                     Here goes something                                         return false

User · Answer

lt img src  images delete png  onclick  return confirm delete  Are you sure     gt       lt script type  text javascript  gt  function confirm delete question       if confirm question          alert  Action to delete        else      return false            lt  script gt

User · Answer

I ve had issue with IE7 and returning false before   Check my answer here to another problem  Javascript not running on IE

User · Answer

I use this  works like a charm  No need to have any functions  just inline with your link s   onclick  javascript return confirm  Are you sure you want to delete this comment

User · Answer

If you want to use small inline commands in the onclick tag you could go with something like this    lt button id    class  delete  onclick  javascript if confirm  Are you sure you want to delete this entry     jQuery this  parent   remove    return false    type  button  gt      Delete  lt  button gt

User · Answer

I ve had issue with IE7 and returning false before   Check my answer here to another problem  Javascript not running on IE

User · Answer

Using a simple link for an action such as removing a record looks dangerous to me   what if a crawler is trying to index your pages   It will ignore any javascript and follow every link  probably not a good thing   You d better use a form with method  POST    And then you will have an event  OnSubmit  to do exactly what you want

User · Answer

Using a simple link for an action such as removing a record looks dangerous to me   what if a crawler is trying to index your pages   It will ignore any javascript and follow every link  probably not a good thing   You d better use a form with method  POST    And then you will have an event  OnSubmit  to do exactly what you want

User · Answer

I had issue alike  click on button  but after cancel clicked it still removes my object   so made this in such way  hope it helps someone in the future        deleteObject   click function          var url   this href      var confirmText    Are you sure you want to delete this object        if confirm confirmText               ajax               type  POST               url url              success function                     Here goes something                                         return false

User · Answer

lt img src  images delete png  onclick  return confirm delete  Are you sure     gt       lt script type  text javascript  gt  function confirm delete question       if confirm question          alert  Action to delete        else      return false            lt  script gt

User · Answer

I ve had issue with IE7 and returning false before   Check my answer here to another problem  Javascript not running on IE

User · Answer

Using a simple link for an action such as removing a record looks dangerous to me   what if a crawler is trying to index your pages   It will ignore any javascript and follow every link  probably not a good thing   You d better use a form with method  POST    And then you will have an event  OnSubmit  to do exactly what you want

User · Answer

try this   OnClientClick  return  confirm  Are you sure you want to delete this comment

User · Answer

First of all  delete is a reserved word in javascript  I m surprised this even executes for you  When I test it in Firefox  I get a syntax error   Secondly  your HTML looks weird - is there a reason you re closing the opening anchor tags with   gt  instead of just  gt

[javascript] Simple JavaScript problem: onClick confirm not preventing default action

Examples related to javascript

Examples related to html