Access Controller method from another controller in Laravel 5

Question

I have two controllers SubmitPerformanceController and PrintReportController   In PrintReportController I have a method called getPrintReport   How to access this method in SubmitPerformanceController

User · Answer

Try creating a new PrintReportController object in SubmitPerformanceController and calling getPrintReport method directly.

For example lets say I have a function called "Test" in SubmitPerformanceController then I can do something like this:

public function test() { 
  $prc = new PrintReportController();
  $prc->getPrintReport();
 }

User · Answer

This approach also works with same hierarchy of Controller files    printReport   new PrintReportController    prinReport- gt getPrintReport

User · Answer

You shouldn   t  It   s an anti-pattern  If you have a method in one controller that you need to access in another controller  then that   s a sign you need to re-factor   Consider re-factoring the method out in to a service class  that you can then instantiate in multiple controllers  So if you need to offer print reports for multiple models  you could do something like this   class ExampleController extends Controller       public function printReport                  report   new PrintReport  itemToReportOn           return  report- gt render

User · Answer

Here the trait fully emulates running controller by laravel router  including support of middlewares and dependency injection   Tested only with 5 4 version    lt  php  namespace App Traits   use Illuminate Pipeline Pipeline  use Illuminate Routing ControllerDispatcher  use Illuminate Routing MiddlewareNameResolver  use Illuminate Routing SortedMiddleware   trait RunsAnotherController       public function runController  controller   method    index                  middleware    this- gt gatherControllerMiddleware  controller   method             middleware    this- gt sortMiddleware  middleware            return  response    new Pipeline app                 - gt send request                - gt through  middleware              - gt then function   request  use   controller   method                    return app  router  - gt prepareResponse                       request   new ControllerDispatcher app    - gt dispatch                      app  router  - gt current     controller   method                                                                 protected function gatherControllerMiddleware  controller   method                return collect  this- gt controllerMidlleware  controller   method  - gt map function   name                return  array MiddlewareNameResolver  resolve  name  app  router  - gt getMiddleware    app  router  - gt getMiddlewareGroups               - gt flatten               protected function controllerMidlleware  controller   method                return ControllerDispatcher  getMiddleware               controller   method                       protected function sortMiddleware  middleware                return  new SortedMiddleware app  router  - gt middlewarePriority   middleware  - gt all              Then just add it to your class and run the controller  Note  that dependency injection will be assigned with your current route   class CustomController extends Controller       use RunsAnotherController       public function someAction                   controller   app  - gt make  App Http Controllers AnotherController             return  this- gt runController  controller   doSomething

User · Answer

If you need that method in another controller  that means you need to abstract it and make it reusable  Move that implementation into a service class  ReportingService or something similar  and inject it into your controllers   Example    class ReportingService     public function getPrintReport              your implementation here           don t forget to import ReportingService at the top  use Path To Class  class SubmitPerformanceController extends Controller     protected  reportingService    public function   construct ReportingService  reportingService            this- gt reportingService    reportingService         public function reports               call the method       this- gt reportingService- gt getPrintReport           rest of the code here         Do the same for the other controllers where you need that implementation  Reaching for controller methods from other controllers is a code smell

User · Answer

First of all  requesting a method of a controller from another controller is EVIL  This will cause many hidden problems in Laravel s life-cycle   Anyway  there are many solutions for doing that  You can select one of these various ways   Case 1  If you want to call based on Classes  Way 1  The simple way  But you can t add any parameters or authentication with this way    app  App Http Controllers PrintReportContoller  class - gt getPrintReport      Way 2  Divide the controller logic into services   You can add any parameters and something with this  The best solution for your programming life  You can make Repository instead Service   class PrintReportService               public function getPrintReport             return              class PrintReportController extends Controller               public function getPrintReport             return  new PrintReportService - gt getPrintReport             class SubmitPerformanceController               public function getSomethingProxy                          a    new PrintReportService - gt getPrintReport                        return               Case 2  If you want to call based on Routes  Way 1  Use MakesHttpRequests trait that used in Application Unit Testing   I recommend this if you have special reason for making this proxy  you can use any parameters and custom headers  Also this will be an internal request in laravel   Fake HTTP Request  You can see more details for the call method in here   class SubmitPerformanceController extends  App Http Controllers Controller       use  Illuminate Foundation Testing Concerns MakesHttpRequests       protected  baseUrl   null      protected  app   null       function   construct                    Require if you want to use MakesHttpRequests          this- gt baseUrl   request  - gt getSchemeAndHttpHost             this- gt app       app               public function getSomethingProxy                          a    this- gt call  GET     printer report  - gt getContent                        return               However this is not a  good  solution  too   Way 2  Use guzzlehttp client  This is the most terrible solution I think  You can use any parameters and custom headers  too  But this would be making an external extra http request  So HTTP Webserver must be running    client   new Client        base uri    gt  request  - gt getSchemeAndhttpHost         headers    gt  request  - gt header        a    client- gt get   performance submit  - gt getBody  - gt getContents       Finally I am using Way 1 of Case 2  I need parameters and

User · Answer

namespace App Http Controllers     call the controller you want to use its methods use App Http Controllers AdminController   use Illuminate Http Request   use App Http Requests   class MealController extends Controller            public function try call  AdminController  admin            return  admin- gt index

User · Answer

You can access your controller method like this    app  App Http Controllers PrintReportController  - gt getPrintReport      This will work  but it s bad in terms of code organisation  remember to use the right namespace for your PrintReportController   You can extend the PrintReportController so SubmitPerformanceController will inherit that method  class SubmitPerformanceController extends PrintReportController                    But this will also inherit all other methods from PrintReportController    The best approach will be to create a trait  e g  in app Traits   implement the logic there and tell your controllers to use it   trait PrintReport        public function getPrintReport                                Tell your controllers to use this trait   class PrintReportController extends Controller        use PrintReport     class SubmitPerformanceController extends Controller        use PrintReport      Both solutions make SubmitPerformanceController to have getPrintReport method so you can call it with  this- gt getPrintReport    from within the controller or directly as a route  if you mapped it in the routes php   You can read more about traits here

User · Answer

In Controller A  public static function function1      In Controller B  View or anywhere  A  function1

User · Answer

You can use a static method in PrintReportController and then call it from the SubmitPerformanceController like this   namespace App Http Controllers   class PrintReportController extends Controller        public static function getPrintReport               return  Printing report                namespace App Http Controllers   use App Http Controllers PrintReportController   class SubmitPerformanceController extends Controller         public function index               echo PrintReportController  getPrintReport

User · Answer

Calling a Controller from another Controller is not recommended  however if for any reason you have to do it  you can do this    Laravel 5 compatible method  return  App  call  bla bla ControllerName functionName      Note  this will not update the URL of the page   It s better to call the Route instead and let it call the controller   return  Redirect  route  route-name-here

User · Answer

You can access the controller by instantiating it and calling doAction   put use Illuminate Support Facades App  before the controller class declaration     controller   App  make   App Http Controllers YouControllerName     data    controller- gt callAction  controller method    parameters     Also note that by doing this you will not execute any of the middlewares declared on that controller

User · Answer

App  call  App Http Controllers MyController getFoo

User · Answer

Late reply  but I have been looking for this for sometime  This is now possible in a very simple way    Without parameters  return redirect  - gt action  HomeController index      With Parameters  return redirect  - gt action  UserController profile     id    gt  1      Docs  https   laravel com docs 5 6 responses redirecting-controller-actions  Back in 5 0 it required the entire path  now it s much simpler

User · Answer

Well  of course  you can instantiate the other controller and call the method you want  Probably it s not a good practice but I don t know why    otherController   new OtherController     otherController- gt methodFromOtherController  param1   param2         But  doing this  you will have a problem  the other method returns something like response  - gt json  result   and is not it what you want   To resolve this problem  define the first parameter of the other controller s method as    public function methodFromOtherController Request  request   null        When you call methodFromOtherController from the main controller  you will pass null as first parameter value    otherController   new OtherController     otherController- gt methodFromOtherController null   param1   param2         Finally  create a condition at the end of the methodFromOtherController method   public function methodFromOtherController Request  request   null                  if  is null  request         return  result      else       return response  - gt json  result           Once Laravel you ever set  request when it is called by direct route  you can differentiate each situation and return a correspondent value

[laravel] Access Controller method from another controller in Laravel 5

Examples related to laravel

Examples related to laravel-5