Spring 5 0 3 RequestRejectedException The request was rejected because the URL was not normalized

Question

Not sure if this is a bug with Spring 5 0 3 or a new feature to fix things on my end   After the upgrade  I am getting this error  Interestingly this error is only on my local machine  Same code on test environment with HTTPS protocol works fine    Continuing      The reason I am getting this error is because my URL for loading the resultant JSP page is  location thisPage jsp  Evaluating code request getRequestURI   gives me result  WEB-INF somelocation  location thisPage jsp  If I fix URL of JSP page to this location thisPage jsp  things work fine    So my question is  should I remove   from JSP path in code because that s what is required going forward  Or Spring has introduced a bug as the only difference between my machine and test environment is protocol HTTP versus HTTPS     org springframework security web firewall RequestRejectedException  The request was rejected because the URL was not normalized      at org springframework security web firewall StrictHttpFirewall getFirewalledRequest StrictHttpFirewall java 123      at org springframework security web FilterChainProxy doFilterInternal FilterChainProxy java 194      at org springframework security web FilterChainProxy doFilter FilterChainProxy java 186      at org springframework web filter DelegatingFilterProxy invokeDelegate DelegatingFilterProxy java 357      at org springframework web filter DelegatingFilterProxy doFilter DelegatingFilterProxy java 270

User · Answer

setAllowUrlEncodedSlash true  didn t work for me  Still internal method isNormalized return false when having double slash   I replaced StrictHttpFirewall with DefaultHttpFirewall by having the following code only    Bean public HttpFirewall defaultHttpFirewall         return new DefaultHttpFirewall        Working well for me  Any risk by using DefaultHttpFirewall

User · Answer

I encountered the same problem with       Spring Boot version   1 5 10   Spring Security version   4 2 4     The problem occurred on the endpoints  where the ModelAndView viewName was defined with a preceding forward slash  Example   ModelAndView mav   new ModelAndView   your-view-here      If I removed the slash it worked fine  Example    ModelAndView mav   new ModelAndView  your-view-here      I also did some tests with RedirectView and it seemed to work with a preceding forward slash

User · Answer

In my case  the problem was caused by not being logged in with Postman  so I opened a connection in another tab with a session cookie I took from the headers in my Chrome session

User · Answer

Spring Security Documentation mentions the reason for blocking    in the request   For example  it could contain path-traversal sequences  like       or multiple forward slashes      which could also cause pattern-matches to fail  Some containers normalize these out before performing the servlet mapping  but others don   t  To protect against issues like these  FilterChainProxy uses an HttpFirewall strategy to check and wrap the request  Un-normalized requests are automatically rejected by default  and path parameters and duplicate slashes are removed for matching purposes   So there are two possible solutions -  remove double slash  preferred approach  Allow    in Spring Security by customizing the StrictHttpFirewall using the below code   Step 1 Create custom firewall that allows slash in URL   Bean public HttpFirewall allowUrlEncodedSlashHttpFirewall         StrictHttpFirewall firewall   new StrictHttpFirewall        firewall setAllowUrlEncodedSlash true           return firewall     Step 2 And then configure this bean in websecurity  Override public void configure WebSecurity web  throws Exception          formatter off     super configure web       web httpFirewall allowUrlEncodedSlashHttpFirewall             Step 2 is an optional step  Spring Boot just needs a bean to be declared of type HttpFirewall and it will auto-configure it in filter chain  Spring Security 5 4 Update In Spring security 5 4 and above  Spring Boot  gt   2 4 0   we can get rid of too many logs complaining about the request rejected by creating the below bean  import org springframework security web firewall RequestRejectedHandler  import org springframework security web firewall HttpStatusRequestRejectedHandler    Bean RequestRejectedHandler requestRejectedHandler        return new HttpStatusRequestRejectedHandler

User · Answer

In my case  upgraded from spring-securiy-web 3 1 3 to 4 2 12  the defaultHttpFirewall was changed from DefaultHttpFirewall to StrictHttpFirewall by default  So just define it in XML configuration like below    lt bean id  defaultHttpFirewall  class  org springframework security web firewall DefaultHttpFirewall   gt   lt sec http-firewall ref  defaultHttpFirewall   gt    set HTTPFirewall as DefaultHttpFirewall

User · Answer

Below solution is a clean work around It does not compromises security because we are using same strict firewall   The Steps for fixing is as below   STEP 1   Create a Class overriding StrictHttpFirewall as below   package com biz brains project security firewall   import java util Arrays  import java util Collection  import java util Collections  import java util HashSet  import java util List  import java util Set   import javax servlet http HttpServletRequest  import javax servlet http HttpServletResponse   import org springframework http HttpMethod  import org springframework security web firewall DefaultHttpFirewall  import org springframework security web firewall FirewalledRequest  import org springframework security web firewall HttpFirewall  import org springframework security web firewall RequestRejectedException   public class CustomStrictHttpFirewall implements HttpFirewall       private static final Set lt String gt  ALLOW ANY HTTP METHOD   Collections unmodifiableSet Collections emptySet          private static final String ENCODED PERCENT     25        private static final String PERCENT             private static final List lt String gt  FORBIDDEN ENCODED PERIOD   Collections unmodifiableList Arrays asList   2e     2E          private static final List lt String gt  FORBIDDEN SEMICOLON   Collections unmodifiableList Arrays asList        3b     3B          private static final List lt String gt  FORBIDDEN FORWARDSLASH   Collections unmodifiableList Arrays asList   2f     2F          private static final List lt String gt  FORBIDDEN BACKSLASH   Collections unmodifiableList Arrays asList         5c     5C          private Set lt String gt  encodedUrlBlacklist   new HashSet lt String gt          private Set lt String gt  decodedUrlBlacklist   new HashSet lt String gt          private Set lt String gt  allowedHttpMethods   createDefaultAllowedHttpMethods         public CustomStrictHttpFirewall             urlBlacklistsAddAll FORBIDDEN SEMICOLON           urlBlacklistsAddAll FORBIDDEN FORWARDSLASH           urlBlacklistsAddAll FORBIDDEN BACKSLASH            this encodedUrlBlacklist add ENCODED PERCENT           this encodedUrlBlacklist addAll FORBIDDEN ENCODED PERIOD           this decodedUrlBlacklist add PERCENT              public void setUnsafeAllowAnyHttpMethod boolean unsafeAllowAnyHttpMethod            this allowedHttpMethods   unsafeAllowAnyHttpMethod   ALLOW ANY HTTP METHOD   createDefaultAllowedHttpMethods               public void setAllowedHttpMethods Collection lt String gt  allowedHttpMethods            if  allowedHttpMethods    null                throw new IllegalArgumentException  allowedHttpMethods cannot be null                      if  allowedHttpMethods    ALLOW ANY HTTP METHOD                this allowedHttpMethods   ALLOW ANY HTTP METHOD            else               this allowedHttpMethods   new HashSet lt  gt  allowedHttpMethods                        public void setAllowSemicolon boolean allowSemicolon            if  allowSemicolon                urlBlacklistsRemoveAll FORBIDDEN SEMICOLON             else               urlBlacklistsAddAll FORBIDDEN SEMICOLON                        public void setAllowUrlEncodedSlash boolean allowUrlEncodedSlash            if  allowUrlEncodedSlash                urlBlacklistsRemoveAll FORBIDDEN FORWARDSLASH             else               urlBlacklistsAddAll FORBIDDEN FORWARDSLASH                        public void setAllowUrlEncodedPeriod boolean allowUrlEncodedPeriod            if  allowUrlEncodedPeriod                this encodedUrlBlacklist removeAll FORBIDDEN ENCODED PERIOD             else               this encodedUrlBlacklist addAll FORBIDDEN ENCODED PERIOD                        public void setAllowBackSlash boolean allowBackSlash            if  allowBackSlash                urlBlacklistsRemoveAll FORBIDDEN BACKSLASH             else               urlBlacklistsAddAll FORBIDDEN BACKSLASH                        public void setAllowUrlEncodedPercent boolean allowUrlEncodedPercent            if  allowUrlEncodedPercent                this encodedUrlBlacklist remove ENCODED PERCENT               this decodedUrlBlacklist remove PERCENT             else               this encodedUrlBlacklist add ENCODED PERCENT               this decodedUrlBlacklist add PERCENT                        private void urlBlacklistsAddAll Collection lt String gt  values            this encodedUrlBlacklist addAll values           this decodedUrlBlacklist addAll values              private void urlBlacklistsRemoveAll Collection lt String gt  values            this encodedUrlBlacklist removeAll values           this decodedUrlBlacklist removeAll values               Override     public FirewalledRequest getFirewalledRequest HttpServletRequest request  throws RequestRejectedException           rejectForbiddenHttpMethod request           rejectedBlacklistedUrls request            if   isNormalized request                 request setAttribute  isNormalized   new RequestRejectedException  The request was rejected because the URL was not normalized                         String requestUri   request getRequestURI            if   containsOnlyPrintableAsciiCharacters requestUri                 request setAttribute  isNormalized    new RequestRejectedException  The requestURI was rejected because it can only contain printable ASCII characters                        return new FirewalledRequest request                 Override             public void reset                                         private void rejectForbiddenHttpMethod HttpServletRequest request            if  this allowedHttpMethods    ALLOW ANY HTTP METHOD                return                    if   this allowedHttpMethods contains request getMethod                   request setAttribute  isNormalized    new RequestRejectedException  The request was rejected because the HTTP method                           request getMethod                             was not included within the whitelist                         this allowedHttpMethods                         private void rejectedBlacklistedUrls HttpServletRequest request            for  String forbidden   this encodedUrlBlacklist                if  encodedUrlContains request  forbidden                     request setAttribute  isNormalized    new RequestRejectedException  The request was rejected because the URL contained a potentially malicious String       forbidden                                           for  String forbidden   this decodedUrlBlacklist                if  decodedUrlContains request  forbidden                     request setAttribute  isNormalized    new RequestRejectedException  The request was rejected because the URL contained a potentially malicious String       forbidden                                               Override     public HttpServletResponse getFirewalledResponse HttpServletResponse response            return new FirewalledResponse response              private static Set lt String gt  createDefaultAllowedHttpMethods             Set lt String gt  result   new HashSet lt  gt             result add HttpMethod DELETE name             result add HttpMethod GET name             result add HttpMethod HEAD name             result add HttpMethod OPTIONS name             result add HttpMethod PATCH name             result add HttpMethod POST name             result add HttpMethod PUT name             return result             private static boolean isNormalized HttpServletRequest request            if   isNormalized request getRequestURI                   return false                    if   isNormalized request getContextPath                   return false                    if   isNormalized request getServletPath                   return false                    if   isNormalized request getPathInfo                   return false                    return true             private static boolean encodedUrlContains HttpServletRequest request  String value            if  valueContains request getContextPath    value                 return true                    return valueContains request getRequestURI    value              private static boolean decodedUrlContains HttpServletRequest request  String value            if  valueContains request getServletPath    value                 return true                    if  valueContains request getPathInfo    value                 return true                    return false             private static boolean containsOnlyPrintableAsciiCharacters String uri            int length   uri length            for  int i   0  i  lt  length  i                  char c   uri charAt i               if  c  lt    u0020     c  gt    u007e                     return false                                   return true             private static boolean valueContains String value  String contains            return value    null  amp  amp  value contains contains              private static boolean isNormalized String path            if  path    null                return true                     if  path indexOf        gt  -1                return false                     for  int j   path length    j  gt  0                 int i   path lastIndexOf      j - 1               int gap   j - i               if  gap    2  amp  amp  path charAt i   1                                          or                      return false                else if  gap    3  amp  amp  path charAt i   1          amp  amp  path charAt i   2                            return false                             j   i                     return true             STEP 2   Create a FirewalledResponse class  package com biz brains project security firewall   import java io IOException  import java util regex Pattern   import javax servlet http Cookie  import javax servlet http HttpServletResponse  import javax servlet http HttpServletResponseWrapper   class FirewalledResponse extends HttpServletResponseWrapper       private static final Pattern CR OR LF   Pattern compile    r   n        private static final String LOCATION HEADER    Location       private static final String SET COOKIE HEADER    Set-Cookie        public FirewalledResponse HttpServletResponse response            super response               Override     public void sendRedirect String location  throws IOException              TODO  implement pluggable validation  instead of simple blacklisting             SEC-1790  Prevent redirects containing CRLF         validateCrlf LOCATION HEADER  location           super sendRedirect location               Override     public void setHeader String name  String value            validateCrlf name  value           super setHeader name  value               Override     public void addHeader String name  String value            validateCrlf name  value           super addHeader name  value               Override     public void addCookie Cookie cookie            if  cookie    null                validateCrlf SET COOKIE HEADER  cookie getName                 validateCrlf SET COOKIE HEADER  cookie getValue                 validateCrlf SET COOKIE HEADER  cookie getPath                 validateCrlf SET COOKIE HEADER  cookie getDomain                 validateCrlf SET COOKIE HEADER  cookie getComment                       super addCookie cookie              void validateCrlf String name  String value            if  hasCrlf name     hasCrlf value                 throw new IllegalArgumentException                       Invalid characters  CR LF  in header     name                        private boolean hasCrlf String value            return value    null  amp  amp  CR OR LF matcher value  find              STEP 3  Create a custom Filter to suppress the RejectedException  package com biz brains project security filter   import java io IOException  import java util Objects   import javax servlet FilterChain  import javax servlet ServletException  import javax servlet ServletRequest  import javax servlet ServletResponse  import javax servlet http HttpServletRequest  import javax servlet http HttpServletResponse   import org springframework core Ordered  import org springframework core annotation Order  import org springframework http HttpHeaders  import org springframework security web firewall RequestRejectedException  import org springframework stereotype Component  import org springframework web filter GenericFilterBean   import lombok extern slf4j Slf4j    Component  Slf4j  Order Ordered HIGHEST PRECEDENCE  public class RequestRejectedExceptionFilter extends GenericFilterBean             Override         public void doFilter ServletRequest servletRequest  ServletResponse servletResponse  FilterChain filterChain  throws IOException  ServletException               try                   RequestRejectedException requestRejectedException  RequestRejectedException  servletRequest getAttribute  isNormalized                    if Objects nonNull requestRejectedException                         throw requestRejectedException                   else                       filterChain doFilter servletRequest  servletResponse                                   catch  RequestRejectedException requestRejectedException                    HttpServletRequest httpServletRequest    HttpServletRequest  servletRequest                  HttpServletResponse httpServletResponse    HttpServletResponse  servletResponse                  log                      error                               request rejected  remote     user agent     request url                                  httpServletRequest getRemoteHost                                  httpServletRequest getHeader HttpHeaders USER AGENT                               httpServletRequest getRequestURL                                 requestRejectedException                                         httpServletResponse sendError HttpServletResponse SC NOT FOUND                               STEP 4  Add the custom filter to spring filter chain in security configuration   Override protected void configure HttpSecurity http  throws Exception        http addFilterBefore new RequestRejectedExceptionFilter                 ChannelProcessingFilter class       Now using above fix  we can handle RequestRejectedException with Error 404  page

User · Answer

Once I used double slash while calling the API then I got the same error   I had to call http   localhost 8080 getSomething but I did Like http   localhost 8080  getSomething  I resolved it by removing extra slash

[spring-mvc] Spring 5.0.3 RequestRejectedException: The request was rejected because the URL was not normalized

Examples related to spring-mvc

Examples related to spring-security