How to change MenuItem icon in ActionBar programmatically

Question

How to change MenuItem icon in ActionBar programmatically  I tried to use  MenuItem menuItem    MenuItem findViewById R id action settings   menuItem setIcon getResources   getDrawable R drawable ic launcher     but it doesn t work  This is my code   MainActivity  package com test  import android os Bundle  import android support v7 app ActionBarActivity  import android view Menu  import android view MenuItem  import android view View  import android widget Button   public class MainActivity extends ActionBarActivity       private Button button       Override     protected void onCreate Bundle savedInstanceState            super onCreate savedInstanceState           setContentView R layout activity main           button    Button findViewById R id button           button setOnClickListener new View OnClickListener                  Override             public void onClick View v                    MenuItem menuItem    MenuItem findViewById R id action settings                   menuItem setIcon getResources   getDrawable R drawable ic launcher                                          Override     public boolean onCreateOptionsMenu Menu menu                Inflate the menu  this adds items to the action bar if it is present          getMenuInflater   inflate R menu main  menu           return true              Override     public boolean onOptionsItemSelected MenuItem item            int id   item getItemId            if  id    R id action settings                return true                    return super onOptionsItemSelected item             main xml   lt menu     xmlns android  http   schemas android com apk res android      xmlns app  http   schemas android com apk res-auto      xmlns tools  http   schemas android com tools      tools context   MainActivity   gt        lt item         android icon   drawable action settings          android id    id action settings          android title   string action settings          android orderInCategory  100          app showAsAction  always   gt   lt  menu gt    activity main   lt LinearLayout     xmlns android  http   schemas android com apk res android      android layout height  fill parent      android layout width  fill parent  gt       lt Button         android id    id button          android text  Set icon          android layout width  wrap content          android layout height  wrap content    gt   lt  LinearLayout gt    This is the exception that i ve had after running   MenuItem menuItem    MenuItem findViewById R id action settings     11-09 19 52 40 471    1735-1735 com test E AndroidRuntime  FATAL EXCEPTION  main     java lang ClassCastException  android support v7 internal view menu ActionMenuItemView             at com test MainActivity 1 onClick MainActivity java 19              at android view View performClick View java 2485              at android view View PerformClick run View java 9080              at android os Handler handleCallback Handler java 587              at android os Handler dispatchMessage Handler java 92              at android os Looper loop Looper java 123              at android app ActivityThread main ActivityThread java 3683              at java lang reflect Method invokeNative Native Method              at java lang reflect Method invoke Method java 507              at com android internal os ZygoteInit MethodAndArgsCaller run ZygoteInit java 839              at com android internal os ZygoteInit main ZygoteInit java 597              at dalvik system NativeStart main Native Method

User · Answer

Lalith s answer is correct   You may also try this approach   button setOnClickListener new View OnClickListener              Override         public void onClick View v                invalidateOptionsMenu                         Override  public boolean onPrepareOptionsMenu Menu menu         MenuItem settingsItem   menu findItem R id action settings          set your desired icon here based on a flag if you like     settingsItem setIcon ContextCompat getDrawable this  R drawable ic launcher          return super onPrepareOptionsMenu menu

User · Answer

Kotlin version  toolbar menu findItem R id notification  icon                       ContextCompat getDrawable requireContext    R drawable ic notification   toolbar menu findItem R id notification  isVisible   true

User · Answer

I resolved this problem this way   In onCreateOptionsMenu   this menu   menu  this menu add  calendar    ImageView imageView   new ImageView getActivity     imageView setMinimumHeight 128   imageView setMinimumWidth 128   imageView setImageDrawable yourDrawable   MenuItem item   this menu getItem 0   item setActionView imageView     in onOptionsItemSelected   if  item getOrder      0          TODO     return true

User · Answer

Instead of getViewById    use  MenuItem item   getToolbar   getMenu   findItem Menu FIRST     replacing the Menu FIRST with your menu item id

User · Answer

Here is how i resolved this    1 -  create a Field Variable like  private Menu mMenuItem   2 - override the method invalidateOptionsMenu      Override public void invalidateOptionsMenu         super invalidateOptionsMenu        3 - call the method invalidateOptionsMenu   in your onCreate    4 - add mMenuItem   menu in your onCreateOptionsMenu Menu menu  like this     Override public boolean onCreateOptionsMenu Menu menu        getMenuInflater   inflate R menu webview menu  menu       mMenuItem   menu      return super onCreateOptionsMenu menu       5 - in the method onOptionsItemSelected MenuItem item  change the icon you want like this     Override public boolean onOptionsItemSelected MenuItem item         switch  item getItemId              case R id R id action settings              mMenuItem getItem 0  setIcon R drawable ic launcher      to change the fav icon               Toast makeText this        mMenuItem getItem 0  getTitle    Toast LENGTH SHORT  show     lt  lt --- this to check if the item in the index 0 is the one you are looking for             return true            return super onOptionsItemSelected item

User · Answer

You can t use findViewById   on menu items in onCreate   because the menu layout isn t inflated yet  You could create a global Menu variable and initialize it in the onCreateOptionsMenu   and then use it in your onClick    private Menu menu   In your onCreateOptionsMenu   this menu   menu   In your button s onClick   method menu getItem 0  setIcon ContextCompat getDrawable this  R drawable ic launcher

User · Answer

This works for me  It should be in your onOptionsItemSelected MenuItem item  method  item setIcon R drawable your icon

User · Answer

Its Working         MenuItem tourchmeMenuItem     Declare Global           public boolean onCreateOptionsMenu Menu menu              getMenuInflater   inflate R menu search  menu           menu findItem R id action search  setVisible false           tourchmeMenuItem   menu findItem R id done           return true          public boolean onOptionsItemSelected MenuItem item         case R id done                         if LoginPreferences getActiveInstance CustomViewFinderScannerActivity this  getIsFlashLight                                 if  Build VERSION SDK INT  gt   Build VERSION CODES M                                    mScannerView setFlash false                                   LoginPreferences getActiveInstance CustomViewFinderScannerActivity this  setIsFlashLight false                                   tourchmeMenuItem setIcon getResources   getDrawable R mipmap torch white 32                                                           else                               if  Build VERSION SDK INT  gt   Build VERSION CODES M                                    mScannerView setFlash true                                   LoginPreferences getActiveInstance CustomViewFinderScannerActivity this  setIsFlashLight true                                   tourchmeMenuItem setIcon getResources   getDrawable R mipmap torch cross white 32                                                                                    break

User · Answer

to use in onMenuItemClick MenuItem item  just do invalidateOptionsMenu    item setIcon ContextCompat getDrawable this  R drawable ic baseline play circle outline 24px

[java] How to change MenuItem icon in ActionBar programmatically

Examples related to java

Examples related to android

Examples related to android-menu