read word by word from file in C

Question

this function should read a file word by word and it does work till the last word  where the run stops   void readFile           ifstream file      file open   program txt        string word      char x       word clear         while     file eof                   x   file get             while   x                                word   word   x              x   file get                           cout lt  lt  word  lt  lt endl              word clear               any one see what is the problem and how it can be solved

User · Accepted Answer

First of all  don t loop while   eof     it will not work as you expect it to because the eofbit will not be set until after a failed read due to end of file   Secondly  the normal input operator  gt  gt  separates on whitespace and so can be used to read  words    std  string word  while  file  gt  gt  word

User · Answer

what you are doing here is reading one character at a time from the input stream and assume that all the characters between     represent a word  BUT it s unlikely to be a     after the last word  so that s probably why it does not work    word1 word2 word2EOF

User · Answer

As others have said  you are likely reading past the end of the file as you re only checking for x         Instead you also have to check for EOF in the inner loop  but in this case don t use a char  but a sufficiently large type    while     file eof           std  ifstream  int type x   file get         while   x         amp  amp  x    std  ifstream  traits type  eof                   word    static cast lt char gt  x           x   file get              std  cout  lt  lt  word  lt  lt    n       word clear        But then again  you can just employ the stream s streaming operators  which already separate at whitespace  and better account for multiple spaces and other kinds of whitepsace    void readFile           std  ifstream file  program txt        for std  string word  file  gt  gt  word            std  cout  lt  lt  word  lt  lt    n       And even further  you can employ a standard algorithm to get rid of the manual loop altogether    include  lt algorithm gt   include  lt iterator gt   void readFile           std  ifstream file  program txt        std  copy std  istream iterator lt std  string gt  file                  std  istream itetator lt std  string gt                    std  ostream iterator lt std  string gt  std  cout    n

User · Answer

If I may I could give you some new code for the same task  in my code you can create a so called  document  not really and it is saved  and can be opened up again  It is also stored as a string file though not a document   Here is the code    include  iostream    include  windows h    include  string    include  fstream   using namespace std   int main      string saveload    cout  lt  lt   ---------------------------   lt  lt  endl  cout  lt  lt    enter  text  to write your document        lt  lt  endl  cout  lt  lt    enter  open file  to open the document     lt  lt  endl  cout  lt  lt   ----------------------------------------   lt  lt  endl  while  true       getline cin  saveload        if  saveload     open file            string filenamet          cout  lt  lt   file name     lt  lt  endl          getline cin  filenamet                ifstream loadFile           loadFile open filenamet  ifstream  in            cout  lt  lt   the text you entered was              while  loadFile good                  cout  lt  lt   char loadFile get                 Sleep 100                      cout  lt  lt      lt  lt  endl           loadFile close                if  saveload     text             string filename          cout  lt  lt   file name     lt  lt  endl          getline cin  filename               string textToSave          cout  lt  lt   Enter your text     lt  lt  endl          getline cin  textToSave                ofstream saveFile filename            saveFile  lt  lt  textToSave           saveFile close             return 0      Just take this code and change it to serve your purpose  DREAM BIG THINK BIG  DO BIG

User · Answer

I have edited the function for you   void readFile         ifstream file      file open   program txt        if   file is open    return       string word      while  file  gt  gt  word                cout lt  lt  word  lt  lt    n

[c++] read word by word from file in C++

Examples related to c++